Add option to show on lock screen

[candrew66]

This option shows the recording screen while the device is locked for easier access to controls and is enabled by default.

Related: #439

[Copilot]

Pull request overview

Adds a new “Show on lock screen” setting to let the recording screen remain visible while the device is locked, improving access to workout controls (related to #439).

Changes:

• Introduces new UI strings and a new “Lock screen visibility” settings category.
• Adds a pref_show_on_lock_screen preference key and a corresponding checkbox in Controls settings (default enabled).
• Updates RunActivity to apply “show when locked” behavior across API levels.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File	Description
common/src/main/res/values/strings.xml	Adds user-facing strings for the new lock screen visibility setting/category.
app/src/main/org/runnerup/view/RunActivity.java	Applies the “show on lock screen” behavior via setShowWhenLocked/window flags and hooks it into lifecycle/back handling.
app/res/xml/settings_controls.xml	Adds a new settings category and checkbox to control lock screen visibility.
app/res/values/pref_keys.xml	Defines the new preference key pref_show_on_lock_screen.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[candrew66]

Would it be ok to rename the Controls settings category to User interface?
I'm thinking of doing a future PR to address #439 using FLAG_KEEP_SCREEN_ON and it makes more sense as a name, just wondering if there's a policy against changing settings names.

[gerhardol]

Would it be ok to rename the Controls settings category to User interface? I'm thinking of doing a future PR to address #439 using FLAG_KEEP_SCREEN_ON and it makes more sense as a name, just wondering if there's a policy against changing settings names.

Renaming is fine. This used to have options to control with play/stop (functionality in Adroid removed in 4.4 or so).

To always keep the screen on is something that Play store reviews tend to block...

[gerhardol]

seem fine, have not run

[candrew66]

Renaming is fine. This used to have options to control with play/stop (functionality in Adroid removed in 4.4 or so).

Thanks, it's renamed in a second commit.

To always keep the screen on is something that Play store reviews tend to block...

I was going to add a Keep screen on option (off by default). I assume this is fine?

[candrew66]

I've left the old translations for the Controls settings category up. Would it be better to remove them?

[gerhardol]

I've left the old translations for the Controls settings category up. Would it be better to remove them?

Please remove

To always keep the screen on is something that Play store reviews tend to block...

I was going to add a Keep screen on option (off by default). I assume this is fine?

The remark is on the permission itself. But we can try.

[gerhardol]

And translated files are updated on Transifex. I will push the new source files, will invalidate the old strings so old strings are removed and new are empty (using default language).

[candrew66]

Right, translations are gone now

[candrew66]

I might keep this PR with only the show on lock screen option to keep it simpler. It should be pretty easy for someone else to do the keep screen on option if they want it.

[gerhardol]

I might keep this PR with only the show on lock screen option to keep it simpler. It should be pretty easy for someone else to do the keep screen on option if they want it.

If you prefer, you can do that in a follow up. I will just revert if it is a problem.