Add option to keep screen on#1355
Open
candrew66 wants to merge 1 commit into
Open
Conversation
This option keeps the screen on while recording (off by default). Fixes jonasoreland#439
There was a problem hiding this comment.
Pull request overview
Adds a new user-facing preference to prevent the display from turning off during an active recording screen, addressing Issue #439 (“Prevent screen from locking”).
Changes:
- Added “Keep screen on” title/summary strings for the settings UI.
- Added a new
pref_keep_screen_onpreference key and UI toggle in User Interface settings. - Applied
FLAG_KEEP_SCREEN_ONinRunActivitybased on the new preference.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| common/src/main/res/values/strings.xml | Adds label/summary strings for the new setting. |
| app/src/main/org/runnerup/view/RunActivity.java | Reads the new preference and applies/clears FLAG_KEEP_SCREEN_ON. |
| app/res/xml/settings_user_interface.xml | Adds a CheckBoxPreference toggle for “Keep screen on”. |
| app/res/values/pref_keys.xml | Defines the new preference key pref_keep_screen_on. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Was thinking of extending the PR but might leave it for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This option keeps the screen on while recording (off by default).
Fixes #439