Manual distance picker miles#458
Closed
gerhardol wants to merge 2 commits into
Closed
Conversation
Also set defaults
Owner
|
the usage of 1000 has to be wrong ? |
Collaborator
Author
|
The change is to instead of entering meters for the minor unit is to enter thousands. So if you set 1.002 miles this would be 1612m. |
Collaborator
Author
|
Any comment on this? |
Collaborator
Author
|
Any suggestion how to not mix miles and meter? |
Collaborator
Author
|
Suggestion: This should be reworked to have one field only but +/- steps complete km/miles |
|
Any update on this. Because it shows as m instead of mi when I upload to runalyze it throws off the distance. |
Collaborator
Author
|
My pull request was rejected, I still consider this as a bug though. How should it look like? |
Collaborator
Author
|
Superseded by #624 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual add distance picker mixed miles and meters
Also set defaults
Still presented as m without unit, but that is a general setup
TitleSpinner: mValue should be split in the presentation and value.