Bump lib/libDaisy: SSD1306 128x32 fix + UART error callback fix - #1
Merged
Conversation
Submodule now points at Synthux-Academy/libDaisy's touchplaited-pin branch (commit 79d048b), carrying two fixes on top of a long-overdue sync with upstream: - SSD1306 128x32 column-start address fix, already filed upstream (electro-smith/libDaisy#707) and merged into Synthux-Academy master. - HAL_UART_ErrorCallback null-safety fix (electro-smith/libDaisy#708, not yet merged anywhere shared). Bisected: this board runs UART MIDI continuously, and a bad interaction with electro-smith's f7c63aee broke the OLED, touch pads, and USB enumeration entirely after boot, while audio/knobs/switches kept working. Reverting the two added lines (an unguarded pointer write) fixed all three, verified on hardware. Kept off Synthux-Academy's shared master since it removes a deliberately-added recovery feature that other projects on that fork may rely on; parked on its own branch there instead so this repo has a durable pin without affecting anyone else. TouchPlaited.cpp now defines USBD_MANUFACTURER_STRING/USBD_PRODUCT_STRING_HS/FS, which the bumped libDaisy requires the application to supply (Synthux fork commits 05fbd468/45657f89) instead of the old hardcoded "Electrosmith"/"Daisy Seed ..." strings; USB now enumerates as "TouchPlaited".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lib/libDaisysubmodule atSynthux-Academy/libDaisy@touchplaited-pin, syncing a very stale (Nov 2024) local snapshot forward and picking up two fixes:HAL_UART_ErrorCallback, filed upstream at Fix HAL_UART_ErrorCallback wedging the system when the Rx listener errors electro-smith/libDaisy#708. Found by bisection: this board runs UART MIDI continuously, and electro-smith's f7c63aee broke OLED updates, touch pads, and USB enumeration entirely after boot while audio/knobs/switches kept working. Kept off Synthux-Academy's shared master since it removes a deliberately-added recovery feature other projects there may depend on; parked on its own branch instead.TouchPlaited.cppnow definesUSBD_MANUFACTURER_STRING/USBD_PRODUCT_STRING_HS/USBD_PRODUCT_STRING_FS, which the bumped libDaisy requires the application to supply. USB now enumerates as "TouchPlaited" instead of generic "Daisy Seed ...".Test plan
lib/libDaisyand firmware both build clean (makeinlib/libDaisy, thenmakeat repo root).