Allow commit info dialog to be resized#109
Open
stdout-se wants to merge 1 commit into
Open
Conversation
Replace commit info window with a custom dialog box to allow it to be resized. Add CommitInfoDialog as a QDialog with the same info and behaviour. The main difference is that the the dialog is user-resizable with a size grip if the details box is shown. Clicking "Show Details..." or "Hide Details..." will enable or disable resizing. Adjust tests and translation catalog for the new dialog. Note: Language files need to be regenerated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem:
QMessageBox.setDetailedText()keeps the window at a fixed size whenever the layout updates, which makes long commit bodies hard to read.GetCommitInfoinmisctasks.py) with a customCommitInfoDialog.CommitInfoDialogkeeps the same look: info icon, HTML summary with parent/signature links, optional read-only details in aQPlainTextEdit, and OK to dismiss.