WIP: Enter key confirms branch checkout#110
Open
stdout-se wants to merge 1 commit into
Open
Conversation
When switching branches, enter key automatically comfirms dialog. WIP questions: - Should it be ctrl+enter? - Should enter confirm, unless user interacts with dialog options?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem
When I double click a commit/branch in the commit graph, I want to be able to quickly just reach over to the enter key and confirm the switch. Right now, the enter key doesn't confirm the dialog.
The change
In the "Check out commit" dialog, Return/Enter should accept the default action (e.g. "Switch Branch") instead of toggling the focused radio button.
CheckoutCommitDialognow marks the OK button as default and installs dialog-level shortcuts that click OK when it is enabled.Note: I kept the commit tagged with WIP to discuss a bit before it's merged.
Questions: