go.mod: bump golang.org/x/tools to latest, go to 1.24.0 - #20
Merged
Conversation
To support Go ≥ 1.24.
Attempting to build copyloopvar with Go 1.25 fails with:
$ go version
go version go1.25.1 linux/amd64
$ go install github.com/karamaru-alpha/copyloopvar/cmd/copyloopvar@latest
# golang.org/x/tools/internal/tokeninternal
../../../../pkg/mod/golang.org/x/tools@v0.18.0/internal/tokeninternal/tokeninternal.go:78:9: invalid array length -delta * delta (constant -256 of type int64)
Fix this by pulling in the latest version of the golang.org/x/tools
package:
$ go get golang.org/x/tools@latest
go: upgraded go 1.21 => 1.24.0
go: upgraded golang.org/x/mod v0.15.0 => v0.28.0
go: upgraded golang.org/x/tools v0.18.0 => v0.37.0
This transitively also updates the Go version in go.mod to
1.24.0.
tklauser
force-pushed
the
bump-x-tools
branch
from
October 27, 2025 16:00
ae51854 to
277e2b2
Compare
Contributor
Author
|
@karamaru-alpha I pushed an additional commit bumping golangci-lint to fix the CI failure. Could you please re-run CI? Thank you! |
Owner
|
Thank you!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempting to build copyloopvar with Go 1.25 fails with:
Fix this by pulling in the latest version of the
golang.org/x/toolspackage:This transitively also updates the Go version in
go.modto 1.24.0.