Release CRD resource lock when the CRD is deleted

[BergCyrill]

Summary

The logicalclustercleanup controller clears a CRD locks expiry while the CRD exists, but the removal branch only fired for locks with a non-nil, passed expiry. So once an established CRD was deleted, its resource-bindings lock was never released, blocking new APIBindings for the same group-resource.

Release the lock when its CRD no longer exists and it has no expiry set.

What Type of PR Is This?

/kind bug

Related Issue(s)

Fixes #3799

Release Notes

NONE

[kcp-ci-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign simontheleg for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kcp-ci-bot]

Hi @BergCyrill. Thanks for your PR.

I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.