-
Notifications
You must be signed in to change notification settings - Fork 2.4k
fix(scheduler): re-implement maintenance mode #13542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fhussonnois
commented
Dec 9, 2025
- Refactor MaintenanceService to be an interface
- Fix VNodeController to also list schedulers in MAINTENANCE state
- Add maintenance mode support for scheduler
5b26384 to
26bbd99
Compare
🐋 Docker imagedocker run --pull=always --rm -it -p 8080:8080 --user=root -v /var/run/docker.sock:/var/run/docker.sock -v /tmp:/tmp ghcr.io/kestra-io/kestra-pr:13542 server local🧪 Java Unit Tests
|
||||||||||||||||||||||||
Tests report quick summary:failed ❌ > tests: 3288, success: 3272, skipped: 14, failed: 2
Failed tests:scheduler > io.kestra.scheduler.DefaultSchedulerTest > shouldStopAndRestartSchedulingLoopWhenEnteringAndExitingMaintenanceMode() failed ❌ in 2.160scheduler > io.kestra.scheduler.TriggerSchedulerTest > shouldSucceedScheduleConditionalScheduleTriggerGivenValidTimeZone() failed ❌ in 1.171Flaky tests report quick summary:failed ❌ > tests: 23, success: 18, skipped: 4, failed: 1
Failed tests:cli > io.kestra.cli.services.FileChangedEventListenerTest > testWithPluginDefault() failed ❌ in 10.380 |
loicmathieu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| // Consumers | ||
| private final List<Disposable> consumerDisposables = new ArrayList<>(); | ||
|
|
||
| private Disposable maintenanceListener; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why didn't you add it to the list of consumerDisposables?
9b6bd43 to
44b37e8
Compare
* Refactor MaintenanceService to be an interface * Fix VNodeController to also list schedulers in MAINTENANCE state * Add maintenance mode support for scheduler
44b37e8 to
b5c867b
Compare