Refactor prune workers to batch by day #1016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issues attributed to commits in this pull requestThis pull request was merged and Sentry observed the following issues:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves pruning query performance by iterating the backlog oldest-first. Previously, pruning would very often "stall" on larger accounts, effectively orphaning older logs due to the exec timeout. This change reworks backlog iteration to process one day at a time, starting from the oldest, ensuring that older logs are eventually pruned even with newer logs pouring in from the large accounts. In addition to resolving the "stall," it should also improve batch query performance.