Skip to content

fix(windows): splash screen is unresponsive #15269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
rc-swag wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

fix(windows): splash screen is unresponsive #15269

rc-swag wants to merge 4 commits into from
+33 −7

Conversation

@rc-swag
Copy link
Contributor

@rc-swag rc-swag commented Dec 3, 2025

No description provided.

@github-project-automation github-project-automation bot moved this to Todo in Keyman Dec 3, 2025
@keymanapp-test-bot keymanapp-test-bot bot added the user-test-missing User tests have not yet been defined for the PR label Dec 3, 2025
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Dec 3, 2025 •
edited
Loading

User Test Results

Test specification and instructions

ERROR: user tests have not yet been defined

Test Artifacts

  • Windows
    • Keyman for Windows - build : all tests passed (no artifacts on BuildLevel "build")
    • FirstVoices Keyboards for Windows - build : all tests passed (no artifacts on BuildLevel "build")
    • FirstVoices Keyboards for Windows (old PRs) - build : all tests passed (no artifacts on BuildLevel "build")
    • Keyman for Windows (old PRs) - build : all tests passed (no artifacts on BuildLevel "build")
    • Text Editor (ARM64) - build : all tests passed (no artifacts on BuildLevel "build")
    • Text Editor (x64) - build : all tests passed (no artifacts on BuildLevel "build")
    • Text Editor (x86) - build : all tests passed (no artifacts on BuildLevel "build")

@keymanapp-test-bot keymanapp-test-bot bot added this to the A19S17 milestone Dec 3, 2025
@rc-swag rc-swag marked this pull request as draft December 3, 2025 01:46
@keyman-server keyman-server modified the milestones: A19S17, A19S18 Dec 6, 2025
@keyman-server keyman-server modified the milestones: A19S18, A19S19 Dec 21, 2025
@rc-swag
Copy link
Contributor Author

rc-swag commented Dec 23, 2025

Notes:

  • If Install Now is true and the shell execute is successful Close or set ModalResult
  • Need to handle the splash screen so get a handle to the splash screen and close it also.
  • Maybe on another PR but add an eventhandler to give a status on the Configurtion to show downloading when downloading is required.

@keyman-server keyman-server modified the milestones: A19S19, A19S20 Jan 3, 2026
@rc-swag
fix(windows): config frm result used to close splash
10f1e24 
The Configuration window will return a mrAbort result when we want
the Splash screen to close. This is in the case the Installation
now has been selected.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

fix user-test-missing User tests have not yet been defined for the PR windows/config/ windows/

Projects

Keyman
Status: Todo

Milestone

A19S20

Development

Successfully merging this pull request may close these issues.

3 participants

@rc-swag @keyman-server