fix: keep items in ListerHaulables after vanilla Cancel (#24)#25
Merged
Merged
Conversation
Designator_HaulUrgently and the on-screen/on-map right-click variants piggybacked DesignationDefOf.Haul alongside KAU_HaulUrgentlyDesignation. Vanilla Designator_Cancel stripped both, routing through ListerHaulables.HaulDesignationRemoved and dropping the item from the haulables list. The vanilla "Prioritize hauling" float-menu option then disappeared until Haul Urgently was re-applied or a pawn finished a natural haul. Items that are EverHaulable && !IsInValidBestStorage are already tracked by ListerHaulables via the spawn path, so the extra vanilla designation was redundant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #24.
Designator_HaulUrgently.DesignateThing(plus the on-screen / on-map right-click variants inThing_Patches.HaulUrgentlyRightClick) was piggybackingDesignationDefOf.Haulonto the same Thing alongsideKAU_HaulUrgentlyDesignation.When the player clicked the vanilla Cancel gizmo on an urgently-marked item:
Designator_Cancel.DesignateThingstripped every cancelable designation, including theHaulone KAU had silently added.ListerHaulables.HaulDesignationRemovedfired and dropped the Thing from the haulables list.ListerHaulablesmembership, no longer appeared until Haul Urgently was re-applied or a pawn finished a natural haul.Items that are
EverHaulable && !IsInValidBestStorage()are already tracked byListerHaulablesvia the spawn path, so the extra vanilla designation was redundant. Removing it leaves the lister state intact across the urgent → cancel cycle.Repro / validation
Reproduced + validated against the save file attached to issue #24 via RimMCP REPL:
HaulListerHaulables