Killbill admin new UI - #16
Merged
Merged
Conversation
Upgrade to Bootstrap 5 (Merge Pending UI Verification)
refactor pagination button styles for improved hover effect and transition
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades Bootstrap from version 3.3.7 to version 5.0.2, representing a major version jump. The changes include:
- Replacing the old unminified Bootstrap 3 JavaScript with both minified and unminified Bootstrap 5 versions
- Adding Bootstrap 5 minified CSS
- Adding a custom theme CSS file with custom color variables and utility classes
- Updating DataTables hover styles to use a simpler opacity-based transition
Reviewed Changes
Copilot reviewed 3 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| app/assets/stylesheets/assets/theme.css | New custom theme file defining Bootstrap color overrides and utility classes |
| app/assets/stylesheets/assets/jquery_datatables.css | Updated pagination button hover styles with opacity-based transitions |
| app/assets/stylesheets/assets/bootstrap.min.css | Added Bootstrap 5.0.2 minified CSS |
| app/assets/javascripts/assets/bootstrap.min.js | Added Bootstrap 5.0.2 minified JavaScript |
| app/assets/javascripts/assets/bootstrap.js | Removed Bootstrap 3.3.7 unminified JavaScript |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fix: correct border-color syntax for .btn-primary class
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assets for new UI