Impl AsyncRead/Write under new tokio feature#29
Draft
sirati wants to merge 4 commits intokixelated:mainfrom
Draft
Impl AsyncRead/Write under new tokio feature#29sirati wants to merge 4 commits intokixelated:mainfrom
sirati wants to merge 4 commits intokixelated:mainfrom
Conversation
how about to do not just discard bytes lmao
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
writing poll code is not trivial so this code needs to be thoroughly checked. Further currently this has commented out code and todos in here, so the code quality is not there yet for a merge.
Besides that the code works to communicate from the browser with a web-transport server
this should be api compatible but for that i had to create a new writer type as the original one was not typed.
mind you i have also again incremented the version but this is for my own consumption