UIEXT-3492: Wait: Hide local file option in remote context#160
Open
PaulBrnrther wants to merge 1 commit intomasterfrom
Open
UIEXT-3492: Wait: Hide local file option in remote context#160PaulBrnrther wants to merge 1 commit intomasterfrom
PaulBrnrther wants to merge 1 commit intomasterfrom
Conversation
PaulBrnrther
requested review from
Copilot and
knime-ghub-bot
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Sleep/Wait node’s WebUI dialog parameters to prevent offering local-file-based “wait for file change” configuration when the local file system is not available (e.g., in a remote context), while still handling existing workflows that already use that mode.
Changes:
- Adds a dynamic
WaitModechoices provider to hideWAIT_FILEwhen local FS isn’t supported (unless already selected). - Adds a local-FS unavailability warning message and disables file-related controls when local FS isn’t supported.
- Updates WebUI snapshot expectations to reflect the new schema/UI rules and initial updates.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| org.knime.base/src/org/knime/base/node/flowcontrol/sleep/SleepNodeParameters.java | Adds dynamic wait-mode option filtering plus warning/disable behavior for file-wait settings in non-local FS contexts. |
| org.knime.base.tests/files/test_snapshots/org.knime.base.node.flowcontrol.sleep.SleepNodeParametersTest1.snap | Updates expected JSON forms/schema/UI snapshot for the parameter model (variant 1). |
| org.knime.base.tests/files/test_snapshots/org.knime.base.node.flowcontrol.sleep.SleepNodeParametersTest.snap | Updates expected JSON forms/schema/UI snapshot for the parameter model (variant 2). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
PaulBrnrther
force-pushed
the
enh/UIEXT-3492-hide-file-settings-in-wait-node
branch
from
fe8a1fd to
036b75d
Compare
Remove the "Wait for file change" option permanently. The WaitMode enum no longer contains WAIT_FILE. For backwards compatibility, settings with the old ordinal (2) are detected on load: - SleepNodeModel.getWaitMode() throws InvalidSettingsException for ordinal 2, causing validateSettings to report a reconfiguration-needed error. - WaitModePersistor catches that exception and returns null which results in no option being selected visually - we show a warning in the dialog on how to procede. Once the user saves the dialog after reconfiguring, wait_option is written as 0 or 1 and it is no longer possible to see the message. UIEXT-3492 (Hide file settings in Wait node)
PaulBrnrther
force-pushed
the
enh/UIEXT-3492-hide-file-settings-in-wait-node
branch
from
036b75d to
33e1059
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UIEXT-3492 (Hide file settings in Wait node)