👻 fixing the image build action due to bug in testing refactor

[shawn-hurley]

Summary by CodeRabbit

• Chores
  • Updated build infrastructure configuration for improved build consistency.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

The pull request adds explicit runner specification to a GitHub Actions workflow job. The generic-external-provider-build job in the image-build workflow now includes runs-on: ubuntu-latest, designating the execution environment without altering job logic or steps.

Changes

Cohort / File(s)	Change Summary
GitHub Actions Workflow Configuration \.github/workflows/image-build.yaml	Added runs-on: ubuntu-latest to the generic-external-provider-build job to explicitly specify Ubuntu runner platform.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

• jmle
• djzager

Poem

🐰 A single line, so small and neat,
Makes workflows run on Ubuntu's beat,
No logic changed, just where it goes,
The rabbit approves—consistency flows! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title describes a bug fix to the image build action, which aligns with the single change of adding runs-on: ubuntu-latest to the generic-external-provider-build job.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d8932ff and 04d9e8c.

📒 Files selected for processing (1)

• .github/workflows/image-build.yaml (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (12)

• GitHub Check: build-all-providers (c-sharp, c-sharp-provider, Dockerfile, konveyor/c-sharp-analyzer-provider, f...
• GitHub Check: build-all-providers (yq, yq-provider, external-providers/yq-external-provider/Dockerfile, true)
• GitHub Check: build-all-providers (generic, generic-provider, external-providers/generic-external-provider/Dock...
• GitHub Check: build-all-providers (java, java-provider, external-providers/java-external-provider/Dockerfile, J...
• GitHub Check: test (macos-latest, darwin, amd64)
• GitHub Check: test (macos-latest, darwin, arm64)
• GitHub Check: test (windows-latest, windows, amd64)
• GitHub Check: test (ubuntu-latest, linux, arm64)
• GitHub Check: test (ubuntu-latest, linux, amd64)
• GitHub Check: benchmark (windows-latest, windows)
• GitHub Check: benchmark (ubuntu-latest, linux)
• GitHub Check: benchmark (macos-latest, mac)

🔇 Additional comments (1)

.github/workflows/image-build.yaml (1)

69-84: Verify the interaction between runs-on and the reusable workflow.

A reusable workflow is called directly within a job using the uses keyword, not from within job steps. When a job uses a reusable workflow, the entire called workflow is used, just as if it was part of the caller workflow. This means the runner specification should come from the reusable workflow itself (defined in konveyor/release-tools/.github/workflows/build-push-images.yaml@main).

Adding runs-on: ubuntu-latest at line 71 to a job that calls a reusable workflow via uses: may not have the intended effect or could conflict with the reusable workflow's runner specification. Additionally, the env: block (line 72-73) on a job using uses: is unusual, as environment variables are typically not inherited by reusable workflows.

Please confirm:

1. Whether the reusable workflow specifies runs-on internally.
2. What the original bug was from the testing refactor (referenced in the PR title).
3. Whether this configuration is the correct fix or if the issue should be addressed in the reusable workflow itself.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}