-
Notifications
You must be signed in to change notification settings - Fork 43
🐛 Add api_hub_tests_ref to CI workflow #501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-0.8
Are you sure you want to change the base?
Conversation
Signed-off-by: Dylan Murray <[email protected]>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| uses: konveyor/ci/.github/workflows/global-ci-bundle.yml@main | ||
| with: | ||
| operator_bundle: ttl.sh/konveyor-operator-bundle-${{ github.sha }}:2h | ||
| api_hub_tests_ref: release-0.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probabaly need both (hub and full API tests ref) like https://github.com/konveyor/tackle2-hub/blob/release-0.8/.github/workflows/main.yml#L94-L97
api_hub_tests_ref: "release-0.8"
api_tests_ref: "release-0.8"
Signed-off-by: Dylan Murray <[email protected]>
| needs: build-operator-bundle | ||
| uses: konveyor/ci/.github/workflows/global-ci-bundle.yml@main | ||
| with: | ||
| operator_bundle: ttl.sh/konveyor-operator-bundle-${{ github.sha }}:2h |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking on test failure with Daytrader, that looks somehow familiar from last weeks, this doesn't setup release-0.8-based Konveyor, at least it is not in the workflow, as a addition to fork branches, we might need specify also https://github.com/konveyor/ci/blob/main/.github/workflows/global-ci-bundle.yml#L16-L25, but maybe I'm wrong, just quickly looked on the failure.
No description provided.