Skip to content

Conversation

@dymurray
Copy link
Contributor

No description provided.

@coderabbitai
Copy link

coderabbitai bot commented Nov 19, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch dymurray-patch-4

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jmle jmle changed the title Add api_hub_tests_ref to CI workflow 🐛 Add api_hub_tests_ref to CI workflow Nov 19, 2025
@jmle jmle self-requested a review November 19, 2025 14:19
uses: konveyor/ci/.github/workflows/global-ci-bundle.yml@main
with:
operator_bundle: ttl.sh/konveyor-operator-bundle-${{ github.sha }}:2h
api_hub_tests_ref: release-0.8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probabaly need both (hub and full API tests ref) like https://github.com/konveyor/tackle2-hub/blob/release-0.8/.github/workflows/main.yml#L94-L97

      api_hub_tests_ref: "release-0.8"
      api_tests_ref: "release-0.8"

Signed-off-by: Dylan Murray <[email protected]>
needs: build-operator-bundle
uses: konveyor/ci/.github/workflows/global-ci-bundle.yml@main
with:
operator_bundle: ttl.sh/konveyor-operator-bundle-${{ github.sha }}:2h
Copy link
Member

@aufi aufi Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking on test failure with Daytrader, that looks somehow familiar from last weeks, this doesn't setup release-0.8-based Konveyor, at least it is not in the workflow, as a addition to fork branches, we might need specify also https://github.com/konveyor/ci/blob/main/.github/workflows/global-ci-bundle.yml#L16-L25, but maybe I'm wrong, just quickly looked on the failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants