Return parameters has been declared as table, default kw in declare block, encoding utf8#27
Return parameters has been declared as table, default kw in declare block, encoding utf8#27kamynina wants to merge 4 commits into
Conversation
|
|
||
| rule dollarQuoteMarker | ||
| '$' tag:( [a-z\200-\377_] [a-z\200-\377_0-9]* )? '$' <Piggly::Parser::Nodes::TDollarQuoteMarker> | ||
| '$' tag:( [a-z\w_] [a-z\w_0-9]* )? '$' <Piggly::Parser::Nodes::TDollarQuoteMarker> |
There was a problem hiding this comment.
Perhaps this should this be [[:alpha:]][[:word:]]*? According to https://ruby-doc.org/core-2.1.1/Regexp.html , \w only matches ASCII characters. I'm not sure if PL/pgSQL allows unicode identifiers, but I don't remember why I matched non-ASCII chars here in the first place!
There was a problem hiding this comment.
If Unicode is not allowed, this a-z\w_0-9 could probably be simplified to \w, but the first part should not match numbers, so probably [a-z][\w]* is the right pattern (must start with a letter).
|
This looks good! If you test where Unicode is and is not allowed and update the regexps accordingly, I'll merge this. |
|
As it so happens I was just about to submit a PR for table return and WITH queries. |
3 participants
No description provided.