-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[docs] Remove ingress-nginx references in docs and scripts jinja template #12768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[docs] Remove ingress-nginx references in docs and scripts jinja template #12768
Conversation
Signed-off-by: Meza <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jmeza-xyz The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @jmeza-xyz. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Meza <[email protected]>
|
/kind documentation |
|
IMO, this PR should just be merged into #12767, unless you have any other better reason. |
|
/ok-to-test |
|
Agree to that, there is not really a reason to separate the two |
|
@tico88612 @VannTen Separated them to make it easier to review but can certainly merge it into the other PR. I'll do that later today and close this one. |
What type of PR is this?
What this PR does / why we need it:
Removes ingress-nginx references from the docs
Which issue(s) this PR fixes:
Fixes #12712
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?: