Skip to content

Conversation

@seungukshin
Copy link

Add support for testing if a node can use virtualization for use by kata-containers (see https://katacontainers.slack.com/archives/C879ACQ00/p1761731112286659). On AMD and Intel platforms this can be determined with CPU feature flags, but on arm64 the situation is more complex. There 2 two flags - ID_AA64PFR0_EL1.EL2 (doc) and ID_AA64MMFR1_EL1.VH (doc)

  • ID_AA64PFR0_EL1.EL2 & 0b0001 != 0 (kernel runs at EL1, hyp world at EL2 - nVHE)
  • ID_AA64MMFR1_EL1.VH & 0b0001 != 0 (kernel is at EL2 using VHE), not visible from user space

Instead, check if kvm is initialized and has created /sys/devices/virtual/misc/kvm.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 7, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: seungukshin / name: Seunguk Shin (d6c54b3)

@netlify
Copy link

netlify bot commented Nov 7, 2025

Deploy Preview for kubernetes-sigs-nfd failed. Why did it fail? →

Name Link
🔨 Latest commit d6c54b3
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-nfd/deploys/693afa67b0e834000892d270

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: seungukshin
Once this PR has been reviewed and has the lgtm label, please assign arangogutierrez for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Welcome @seungukshin!

It looks like this is your first PR to kubernetes-sigs/node-feature-discovery 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/node-feature-discovery has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 7, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @seungukshin. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 7, 2025
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @seungukshin for the contribution. Could you sign the CLA?

@marquiz
Copy link
Contributor

marquiz commented Dec 9, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 9, 2025
@seungukshin
Copy link
Author

Thank you @seungukshin for the contribution. Could you sign the CLA?

Thank you @marquiz and sorry for the delay.
I'm working on CLA from my company side, and probably I could proceed this this week.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 10, 2025
@marquiz
Copy link
Contributor

marquiz commented Dec 10, 2025

I'm working on CLA from my company side, and probably I could proceed this this week.

No problem

This commit adds a feature to check kvm availability.

Signed-off-by: Seunguk Shin <[email protected]>
Reviewed-by: Nick Connolly <[email protected]>
@k8s-ci-robot
Copy link
Contributor

@seungukshin: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-node-feature-discovery-build-image-cross-generic d6c54b3 link true /test pull-node-feature-discovery-build-image-cross-generic

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants