Fix: Use the desktop scale in plugin window#1109
Open
pawel-ulita wants to merge 1 commit into
Open
Conversation
This makes sure that the plugin window itself follows the desktop scale set in the settings. This affects the size of the buttons at the top, and also the size of the contents of the built-in plugins.
|
|
Author
|
I see this may conflict with: #478 At the same time, maybe this is not a problem any more? I don't experience anything like what the issue describes with the native and 3rd party plugins. |
pawel-ulita
commented
May 29, 2026
| } | ||
|
|
||
| float PluginWindow::getDesktopScaleFactor() const { return 1.f; } | ||
| float PluginWindow::getDesktopScaleFactor() const { return (float) juce::Desktop::getInstance().getGlobalScaleFactor(); } |
Author
There was a problem hiding this comment.
Maybe a better way would be to just remove getDesktopScaleFactor() altogether?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes sure that the plugin window itself follows the desktop scale set in the settings. This affects the size of the buttons at the top, and also the size of the contents of the built-in plugins.
Before vs after
BeforeAfter
I have only tested in on Linux, so I'm not sure about the consequences on other operating systems.