Skip to content

Validate that self must be the first parameter in impl method - #236

Open
dsocolobsky wants to merge 1 commit into
mainfrom
dy/validate-self-first-param
Open

Validate that self must be the first parameter in impl method#236
dsocolobsky wants to merge 1 commit into
mainfrom
dy/validate-self-first-param

Conversation

@dsocolobsky

Copy link
Copy Markdown
image

I think this solves #216 ?
Let me know if I need to change anything.

@github-actions

Copy link
Copy Markdown

Benchmarking (macOS) factorial

Compiling factorial (factorial.con)
Finished release in 1.871051667s
Running 5000000 iterations
Using input value: 20
Concrete Result = 2432902008176640000 Time taken : 39.05 ms
Rust Result = 2432902008176640000 Time taken : 33.91 ms

Benchmarking (macOS) fib

Compiling fib (fib.con)
Finished release in 168.960291ms
Running 5000 iterations
Using input value: 20
Concrete Result = 6765 Time taken : 100.83 ms
Rust Result = 6765 Time taken : 109.89 ms

@github-actions

Copy link
Copy Markdown

Benchmarking (Linux) factorial

Compiling factorial (factorial.con)
Finished release in 32.892612ms
Running 5000000 iterations
Using input value: 20
Concrete Result = 2432902008176640000 Time taken : 96.89 ms
Rust Result = 2432902008176640000 Time taken : 60.43 ms

Benchmarking (Linux) fib

Compiling fib (fib.con)
Finished release in 26.116232ms
Running 5000 iterations
Using input value: 20
Concrete Result = 6765 Time taken : 136.93 ms
Rust Result = 6765 Time taken : 85.86 ms

@codecov-commenter

codecov-commenter commented Jul 20, 2025

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.16%. Comparing base (4802a28) to head (73fbbae).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/check/mod.rs 0.00% 12 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #236      +/-   ##
==========================================
- Coverage   56.29%   56.16%   -0.13%     
==========================================
  Files          25       25              
  Lines        5516     5528      +12     
==========================================
  Hits         3105     3105              
- Misses       2411     2423      +12     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants