Reduce allocs for bitmap index #5585
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to address #5494. This improves runtime during bitmap index creation. I'm currently looking to see whether we can group by value, then construct a sorted range all-at-once with from_sorted_iter. Only problem with this is whether we might accumulate the same # of allocs doing a group by on these unique values. In this case, push() optimization will not be needed.
Roaring bitmaps support
RoaringBitmap::pushAPI where the successive calls to the method contain data in monotonically increasing order. This replaces expensiveRoaringBitmap::insertbeing called which:Vec::inserton this container (need to shuffle items around).