Skip to content

Conversation

@ulgut
Copy link

@ulgut ulgut commented Dec 28, 2025

Attempts to address #5494. This improves runtime during bitmap index creation. I'm currently looking to see whether we can group by value, then construct a sorted range all-at-once with from_sorted_iter. Only problem with this is whether we might accumulate the same # of allocs doing a group by on these unique values. In this case, push() optimization will not be needed.

Roaring bitmaps support RoaringBitmap::push API where the successive calls to the method contain data in monotonically increasing order. This replaces expensive RoaringBitmap::insert being called which:

  1. Does a binary search to find the appropriate container.
  2. Runs a linearVec::insert on this container (need to shuffle items around).

@github-actions
Copy link
Contributor

ACTION NEEDED
Lance follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

For details on the error please inspect the "PR Title Check" action.

@ulgut ulgut closed this Dec 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant