feat: support FixedSizeList<Struct> #5593
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, FixedSizeList was only supported with primitive element types (e.g., FSL<Float32> for vectors). This adds structural encoding support for FSL<Struct>, enabling use cases like fixed-size arrays of bounding boxes, coordinate tuples, or other structured data. Key changes: - New `FixedSizeListStructuralEncoder` that encodes FSL validity to rep/def and delegates child encoding to the struct encoder - New `StructuralFixedSizeListScheduler` that scales row ranges by the FSL dimension when scheduling reads - New `StructuralFixedSizeListDecoder` that reconstructs FSL arrays from child data and rep/def validity A key challenge is "garbage filtering": unlike variable-length lists which can omit children under null entries, FSL children always exist. When an FSL row is null, any nested list-like types within its children contain undefined "garbage" data. The encoder normalizes these to empty null lists before encoding.
wkalt
changed the title
Contributor
Author
|
sorry, mislabeled this breaking. Should not be breaking. |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Contributor
Author
|
I will update this patch once #5591 is merged - there are some related tests I want to add here that currently fail. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, FixedSizeList was only supported with primitive element types (e.g., FSL for vectors). This adds structural encoding support for FSL, enabling use cases like fixed-size arrays of bounding boxes, coordinate tuples, or other structured data.
Key changes:
FixedSizeListStructuralEncoderthat encodes FSL validity to rep/def and delegates child encoding to the struct encoderStructuralFixedSizeListSchedulerthat scales row ranges by the FSL dimension when scheduling readsStructuralFixedSizeListDecoderthat reconstructs FSL arrays from child data and rep/def validityA key challenge is "garbage filtering": unlike variable-length lists which can omit children under null entries, FSL children always exist. When an FSL row is null, any nested list-like types within its children contain undefined "garbage" data. The encoder normalizes these to empty null lists before encoding.