Skip to content

Added RU and KO locales - #12739

Open
gefestdev wants to merge 2 commits into
langflow-ai:mainfrom
gefestdev:hotfix/add-korean-and-russian-locales
Open

Added RU and KO locales#12739
gefestdev wants to merge 2 commits into
langflow-ai:mainfrom
gefestdev:hotfix/add-korean-and-russian-locales

Conversation

@gefestdev

@gefestdev gefestdev commented Apr 16, 2026

Copy link
Copy Markdown

Summary by CodeRabbit

Release Notes

  • New Features
    • Added Korean language support with localized error messages, alerts, dialogs, and UI labels across the application
    • Added Russian language support with localized error messages, alerts, dialogs, and UI labels across the application

@gefestdev
gefestdev marked this pull request as draft April 16, 2026 11:33
@coderabbitai

coderabbitai Bot commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ca2a6703-a785-494a-8b92-6ef5be65d61b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Walkthrough

Two new localization files added to the frontend: Korean and Russian translations providing error messages, success notifications, UI labels, alerts, dialogs, flow-related text, settings, admin features, authentication, and various component-specific strings with template placeholders.

Changes

Cohort / File(s) Summary
Localization Resources
src/frontend/src/locales/ko.json, src/frontend/src/locales/ru.json
Added Korean and Russian translation files with 388 key-value pairs each covering errors, alerts, dialogs, chat, flows, settings, admin, nodes, auth, and UI labels with template variables ({{maxSizeMB}}, {{count}}, {{flowType}}, etc.).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error)

Check name Status Explanation Resolution
Test Coverage For New Implementations ❌ Error PR adds two new locale files (ko.json and ru.json) without any corresponding test files or validation mechanisms to ensure JSON validity and key consistency. Add a locale validation test file using Jest to validate JSON structure, ensure all keys from en.json are present, and verify no formatting issues exist.
✅ Passed checks (6 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Added RU and KO locales' directly and accurately describes the main change: adding Russian and Korean localization files to the frontend.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Test Quality And Coverage ✅ Passed Pull request adds localization JSON files for Korean and Russian languages. These are data files containing UI translations, not code implementations requiring unit tests, async testing, or API endpoint validation.
Test File Naming And Structure ✅ Passed The custom check for Test File Naming and Structure is not applicable as this PR only adds localization resource files without any test files.
Excessive Mock Usage Warning ✅ Passed No test files are modified in this PR, which only updates localization resource files, so the custom check for excessive mock usage is not applicable and passes by default.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gefestdev
gefestdev marked this pull request as ready for review April 16, 2026 11:34

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/frontend/src/locales/ko.json`:
- Line 3: Fix the typo in the Korean translation for the key
"errors.missedFields" in src/frontend/src/locales/ko.json: change "저런! 뭔가 빠뜌린 것
같습니다." to "저런! 뭔가 빠뜨린 것 같습니다." so the correct spelling "빠뜨린" is used; update
only the value for the "errors.missedFields" key.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 2b8837d9-9fd3-4a29-8ad8-d6f01831cda6

📥 Commits

Reviewing files that changed from the base of the PR and between 9aae6de and 1de0ae1.

📒 Files selected for processing (2)
  • src/frontend/src/locales/ko.json
  • src/frontend/src/locales/ru.json

Comment thread src/frontend/src/locales/ko.json
@gefestdev

Copy link
Copy Markdown
Author

Fixes #12740

@YeonghyeonKO

Copy link
Copy Markdown
Contributor

@gefestdev Hi, thanks for your work on adding RU and KO locales!

Just a heads-up — I actually reported the underlying crash caused by a missing default locale fallback and opened a PR that fixes it and also adds the Korean locale a few days ago.

You can find them here:

It might be worth coordinating so our changes don’t overlap — perhaps your PR could focus on the Russian locale, and we could rebase on top of #12733 once the fallback fix is merged. Happy to collaborate however works best. 🙌

@gefestdev

Copy link
Copy Markdown
Author

@gefestdev Hi, thanks for your work on adding RU and KO locales!

Just a heads-up — I actually reported the underlying crash caused by a missing default locale fallback and opened a PR that fixes it and also adds the Korean locale a few days ago.

You can find them here:

* Issue: [bug(i18n): loadLanguage() crashes on unsupported browser locale (missing fallback) #12735](https://github.com/langflow-ai/langflow/issues/12735)

* PR: [feat(i18n): add Korean locale and graceful fallback for missing locales #12733](https://github.com/langflow-ai/langflow/pull/12733)

It might be worth coordinating so our changes don’t overlap — perhaps your PR could focus on the Russian locale, and we could rebase on top of #12733 once the fallback fix is merged. Happy to collaborate however works best. 🙌

Hey, @YeonghyeonKO! I will be able to merge my locale into your branch for some time.

@YeonghyeonKO

Copy link
Copy Markdown
Contributor

@gefestdev Thanks!
I m looking forward to communicate with maintainers and our PR to be reviewed and merged soon :)

@gefestdev

Copy link
Copy Markdown
Author

@YeonghyeonKO
Can you tell me how we can combine both of our changes? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants