Added RU and KO locales - #12739
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughTwo new localization files added to the frontend: Korean and Russian translations providing error messages, success notifications, UI labels, alerts, dialogs, flow-related text, settings, admin features, authentication, and various component-specific strings with template placeholders. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error)
✅ Passed checks (6 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/frontend/src/locales/ko.json`:
- Line 3: Fix the typo in the Korean translation for the key
"errors.missedFields" in src/frontend/src/locales/ko.json: change "저런! 뭔가 빠뜌린 것
같습니다." to "저런! 뭔가 빠뜨린 것 같습니다." so the correct spelling "빠뜨린" is used; update
only the value for the "errors.missedFields" key.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 2b8837d9-9fd3-4a29-8ad8-d6f01831cda6
📒 Files selected for processing (2)
src/frontend/src/locales/ko.jsonsrc/frontend/src/locales/ru.json
|
Fixes #12740 |
|
@gefestdev Hi, thanks for your work on adding RU and KO locales! Just a heads-up — I actually reported the underlying crash caused by a missing default locale fallback and opened a PR that fixes it and also adds the Korean locale a few days ago. You can find them here:
It might be worth coordinating so our changes don’t overlap — perhaps your PR could focus on the Russian locale, and we could rebase on top of #12733 once the fallback fix is merged. Happy to collaborate however works best. 🙌 |
Hey, @YeonghyeonKO! I will be able to merge my locale into your branch for some time. |
|
@gefestdev Thanks! |
|
@YeonghyeonKO |
Summary by CodeRabbit
Release Notes