feat: open graph redesign#2859
Open
tomaszantas wants to merge 12 commits intolangfuse:mainfrom
Open
Conversation
Main upstream
|
@tomaszantas is attempting to deploy a commit to the langfuse Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
@claude pls review |
Contributor
|
@claude pls review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR redesigns the OG image from dark (black background, white wordmark) to a light beige theme with per-line yellow highlight strips on the title.
How to test
pnpm run devDisclaimer: Experimental PR review
Greptile Summary
This PR replaces the dark OG image design with a light-beige theme: per-line yellow highlight strips for the title (rendered via a custom
wrapWordssplitter), an inline-base64 background PNG, and a simplified footer. The font-size ladder and chunkedtoDataUrlimplementation are well-reasoned for the Edge runtime.sectionquery parameter is no longer read by the route handler, butlib/og-url.tsand its callers (lib/mdx-page.ts,app/faq/[[...slug]]/page.tsx) still append it to every OG URL — the section label silently disappears for all those pages without any cleanup of the dead interface.Confidence Score: 4/5
Safe to merge after addressing the dead
sectionparameter in the OG URL helper and its callersOne P1 finding: the
sectioninterface in lib/og-url.ts and its callers was not cleaned up, leaving a dead parameter that silently drops OG section labels. All other findings are P2.lib/og-url.ts and app/faq/[[...slug]]/page.tsx still reference the removed
sectionparameterImportant Files Changed
sectionparam rendering but callers in lib/og-url.ts still append it silentlyFlowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A[GET /api/og] --> B[Fetch resources in parallel] B --> B1[og-bg.png — nullable] B --> B2[GeistMono-Medium.ttf] B --> B3[Inter-Medium.ttf] B1 & B2 & B3 --> C[Parse query params] C --> D{title length?} D -->|>80 chars| E[fontSize = 42] D -->|>40 chars| F[fontSize = 58] D -->|>28 chars| G[fontSize = 72] D -->|≤28 chars| H[fontSize = 90] E & F & G & H --> I[wrapWords → titleLines array] I --> J[Render ImageResponse] J --> J1{ogBgData?} J1 -->|yes| K[Render bg img via toDataUrl] J1 -->|no| L[BG_COLOR fallback only] K & L --> M[Render title lines with yellow highlights] M --> N[Render description] N --> O[Render footer] O --> P[Return 1200×630 PNG]Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "clean up" | Re-trigger Greptile