General Improvements#2899
Closed
bezbac wants to merge 10 commits into
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
f319dae to
af5b6a0
Compare
|
@claude review |
Member
Author
|
Cherry picked to main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Disclaimer: Experimental PR review
Greptile Summary
This PR delivers a broad set of UI and content improvements: a new styled
Details/Summarycomponent pair replaces native HTML<details>/<summary>across docs, marketing, and handbook pages, and a reusablePageFooterNavcomponent is extracted fromDocsFooterand added to blog and changelog post pages.Details/Summarycomponents (components/Details.tsx): controlled component pair usingDetailsContextfor styling sync; replaces CSS hacks inoverrides.css. All existing MDX content has been updated to use the capitalized React components.PageFooterNav+getPageFooterItems(components/PageFooterNav.tsx,lib/page-footer-nav.ts): footer navigation extracted into a shared component and utility, then wired into blog and changelog post pages so readers can step through posts in chronological order.FileTreegets inline CSS variable theming;Availabilitybanner redesigned;BrandAssetCardsimplified by dropping the redundanthrefprop in favour of reusingsrc.Confidence Score: 4/5
Safe to merge; all changes are additive UI work with no data-path risk.
The two flagged items are minor quality issues that don't affect any currently rendered page.
getPageFooterItemsmutates its input array but current callers pass.filter()results; the missingsummarymapping in mdx-components could cause styling gaps only for future content written with lowercase tags.lib/page-footer-nav.ts(sort mutation) andmdx-components.tsx(missingsummarymapping) are worth a quick look; all other files look clean.Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A["MDX Content"] -->|"details mapping"| B["Details component"] B --> C["Summary component"] B --> D["Content children"] E["Blog/Changelog page.tsx"] -->|"getPageFooterItems()"| F["lib/page-footer-nav.ts"] F --> G["PageFooterNav"] H["DocsFooter.tsx"] -->|"useFooterItems()"| I["resolvedItems"] I --> GPrompt To Fix All With AI
Reviews (1): Last reviewed commit: "fix: `Availability` component styling" | Re-trigger Greptile