Skip to content

General Improvements#2899

Closed
bezbac wants to merge 10 commits into
mainfrom
ben/improvements
Closed

General Improvements#2899
bezbac wants to merge 10 commits into
mainfrom
ben/improvements

Conversation

@bezbac
Copy link
Copy Markdown
Member

@bezbac bezbac commented May 7, 2026

Issues

  • Resolves LFE-9401
  • Resolves MKT-2059
  • Resolves LFE-9396
  • Resolves LFE-9459
  • Resolves LFE-9302
  • Resolves LFE-9397
  • Resolves LFE-9555
  • Resolves LFE-9556

Disclaimer: Experimental PR review

Greptile Summary

This PR delivers a broad set of UI and content improvements: a new styled Details/Summary component pair replaces native HTML <details>/<summary> across docs, marketing, and handbook pages, and a reusable PageFooterNav component is extracted from DocsFooter and added to blog and changelog post pages.

  • New Details/Summary components (components/Details.tsx): controlled component pair using DetailsContext for styling sync; replaces CSS hacks in overrides.css. All existing MDX content has been updated to use the capitalized React components.
  • PageFooterNav + getPageFooterItems (components/PageFooterNav.tsx, lib/page-footer-nav.ts): footer navigation extracted into a shared component and utility, then wired into blog and changelog post pages so readers can step through posts in chronological order.
  • Layout & styling updates: max-width raised from 1440 px to 1520 px across navbars, secondary nav, and the layout wrapper; FileTree gets inline CSS variable theming; Availability banner redesigned; BrandAssetCard simplified by dropping the redundant href prop in favour of reusing src.

Confidence Score: 4/5

Safe to merge; all changes are additive UI work with no data-path risk.

The two flagged items are minor quality issues that don't affect any currently rendered page. getPageFooterItems mutates its input array but current callers pass .filter() results; the missing summary mapping in mdx-components could cause styling gaps only for future content written with lowercase tags.

lib/page-footer-nav.ts (sort mutation) and mdx-components.tsx (missing summary mapping) are worth a quick look; all other files look clean.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["MDX Content"] -->|"details mapping"| B["Details component"]
    B --> C["Summary component"]
    B --> D["Content children"]
    E["Blog/Changelog page.tsx"] -->|"getPageFooterItems()"| F["lib/page-footer-nav.ts"]
    F --> G["PageFooterNav"]
    H["DocsFooter.tsx"] -->|"useFooterItems()"| I["resolvedItems"]
    I --> G
Loading
Prompt To Fix All With AI
Fix the following 2 code review issues. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 2
lib/page-footer-nav.ts:14-19
The `pages.sort()` call mutates the array that was passed in. The current callers always pass a fresh array from `.filter()`, so there's no observable breakage today, but any future caller that passes the raw `getPages()` result directly would silently corrupt the source order for the rest of the render. Spread the array before sorting to make the function safe regardless of caller.

```suggestion
  const footerPages = [...pages]
    .sort(
      (a, b) =>
        new Date(options.getDate(a) ?? 0).getTime() -
        new Date(options.getDate(b) ?? 0).getTime(),
    )
```

### Issue 2 of 2
mdx-components.tsx:70-71
The `details` element is remapped to the custom `Details` component, but `summary` is not remapped to `Summary`. If any MDX content uses lowercase `` without explicitly importing `Summary`, the outer `Details` wrapper will apply its corner-box styling and `DetailsContext`, but the `<summary>` will render as a plain HTML element — no striped header, no `+/-` toggle icon, and no hover styling. Adding `summary: Summary` keeps the pair consistent.

```suggestion
    details: Details,
    summary: Summary,
    ...components,
```

Reviews (1): Last reviewed commit: "fix: `Availability` component styling" | Re-trigger Greptile

Greptile also left 2 inline comments on this PR.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
langfuse-docs Ready Ready Preview, Comment May 10, 2026 6:56pm

Request Review

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

@claude review

@dosubot dosubot Bot added the documentation Improvements or additions to documentation label May 8, 2026
Comment thread lib/page-footer-nav.ts Outdated
Comment thread mdx-components.tsx
Comment thread mdx-components.tsx
Comment thread components/Availability.tsx
Comment thread components/layout/SharedDocsLayout.tsx
Comment thread components/home/GetStartedSection.tsx Outdated
Comment thread components/docs/file-tree.tsx Outdated
Comment thread components/Availability.tsx Outdated
@bezbac bezbac force-pushed the ben/improvements branch from a66d2df to 6bd5fcb Compare May 8, 2026 14:56
@bezbac
Copy link
Copy Markdown
Member Author

bezbac commented May 11, 2026

Cherry picked to main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant