Add unit tests for PauliStringLCU block encoding - #94
Open
cferenba wants to merge 5 commits into
Open
Conversation
Member
Author
|
I found that my contraction of the select bits shouldn't have been necessary - it was only needed to work around a bug in Qualtran 0.4.0. I've backported a fix from 0.5.0 and that allows me to simplify the tests nicely. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds two unit tests for the (Qualtran-based) PauliStringLCU block encoding, which verify that the upper corner of the generated block encoding is equal to the original Hamiltonian, up to a scale factor. It also does some cleanup of the PauliStringLCU logic and fixes a minor bug.
EDIT: I've also added the same two tests for the PyLIQTR version of the encoding.