Skip to content

[12.x] Remove the assertSentTimes method and add the hasMetadata method. #10949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kevinb1989 wants to merge 2 commits into
base: 12.x
Choose a base branch
from
Open

[12.x] Remove the assertSentTimes method and add the hasMetadata method. #10949

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9a5b52
Remove the assertSentTimes method and add the hasMetadata method.
kevinb1989 Dec 13, 2025
2e30d81
also remove the assertSentTimes method for the PHPUnit tab.
kevinb1989 Dec 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions mail.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1262,9 +1262,6 @@ test('orders can be shipped', function () {
// Assert a mailable was not sent...
Mail::assertNotSent(AnotherMailable::class);

// Assert a mailable was sent twice...
Mail::assertSentTimes(OrderShipped::class, 2);

// Assert 3 total mailables were sent...
Mail::assertSentCount(3);
});
Expand Down Expand Up @@ -1305,9 +1302,6 @@ class ExampleTest extends TestCase
// Assert a mailable was not sent...
Mail::assertNotSent(AnotherMailable::class);

// Assert a mailable was sent twice...
Mail::assertSentTimes(OrderShipped::class, 2);

// Assert 3 total mailables were sent...
Mail::assertSentCount(3);
}
Expand Down Expand Up @@ -1341,6 +1335,7 @@ Mail::assertSent(OrderShipped::class, function (OrderShipped $mail) use ($user)
$mail->hasReplyTo('...') &&
$mail->hasFrom('...') &&
$mail->hasSubject('...') &&
$mail->hasMetadata('order_id', $mail->order->id) &&
$mail->usesMailer('ses');
});
```
Expand Down