Conversation
|
@launchdarkly/js-sdk-common size report |
|
@launchdarkly/browser size report |
|
@launchdarkly/js-client-sdk size report |
|
@launchdarkly/js-client-sdk-common size report |
joker23
force-pushed
the
skz/sdk-1813/rsc-ssr-example
branch
5 times, most recently
from
c043a28 to
a638247
Compare
joker23
force-pushed
the
skz/sdk-1813/rsc-ssr-example
branch
from
a638247 to
1b62a24
Compare
|
@cursor review |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| aws_assume_role: ${{ inputs.aws_assume_role }} | ||
| ssm_parameter_pairs: '/sdk/common/hello-apps/client-key = LAUNCHDARKLY_CLIENT_SIDE_ID' | ||
|
|
||
| - uses: launchdarkly/gh-actions/actions/release-secrets@1a3dc56945c8e87bc952119b055f9481b4d642b0 |
There was a problem hiding this comment.
adding this for server sdk testing ... we can also choose to add a param for this action so different workflows can enable different keys, for now I am just loading all of the envs since there are no naming conflicts
| // in this render tree can retrieve it via useLDServerSession() — no prop drilling needed. | ||
| createLDServerSession(ldBaseClient, context); | ||
|
|
||
| return <App />; |
There was a problem hiding this comment.
NOTE: also that I separated this with App.tsx since a more realistic application of this example is for developers to already have a "global" server sdk client that they would create this session out of. This is what the Page.tsx is suppose to represent (The top level set up for this SDK)
1 participant
Note
Medium Risk
Adds a new Next.js server-rendered example plus Playwright e2e coverage and updates CI to fetch a server-side SDK key; failures or misconfiguration could break React workflow runs and secret injection.
Overview
Adds a new React server-only (RSC) example app (
packages/sdk/react/examples/server-only) that evaluates a LaunchDarkly flag on the server usingcreateLDServerSession/useLDServerSession, including basic styling, docs, and a Playwright e2e smoke test.Updates the monorepo and CI to run it: includes the new workspace in root
package.json, adds a dedicatedrun-server-only-exampleGitHub Actions job, and extends the sharedactions/run-examplecomposite action to also fetchLAUNCHDARKLY_SDK_KEYfrom SSM (in addition to the existing client key/flag key).Written by Cursor Bugbot for commit 1b62a24. This will update automatically on new commits. Configure here.