Conversation
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
react-server-docs | 23cb57c | Mar 06 2026, 08:24 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings the
react-server.config.*validation schema to full parity with Vite 8, marks internally-hardcoded options as forbidden with clear error messages, and adds a--no-validationCLI flag as an escape hatch.Problem
The config validation schema was missing many Vite options (e.g.
server.ws,server.strictPort,server.allowedHosts, etc.), causing false validation errors when users set legitimate Vite configuration. Additionally, several Vite options that react-server hardcodes internally (likeappType,build.target,json) were silently accepted but then overwritten at runtime, leading to confusing behavior.Changes
Schema parity with Vite 8
Added validators, TypeScript types, JSON Schema definitions, and descriptions for all previously missing Vite config options across every section.
Forbidden options
Introduced a
forbidden()validator that produces clear error messages explaining why an option is forbidden and what to use instead. The following options are now forbidden because react-server hardcodes them internally:--no-validationCLI flagAdded
--no-validationto bothdevandbuildcommands as an escape hatch. When set, config validation is completely skipped. This is useful if validation incorrectly rejects a valid configuration or when users intentionally need to bypass a forbidden option.Documentation (EN + JA)
--no-validationdocumentation under both development server and build option sections