Remove blocked and filtered reducers/selectors/actions.#7682
Open
Remove blocked and filtered reducers/selectors/actions.#7682
Conversation
jessopb
requested changes
Aug 31, 2022
Member
jessopb
left a comment
There was a problem hiding this comment.
Nice. I don't think there's any reason to leave those empty arrays in. Removing them can only simplify the related components. Yes?
jessopb
requested changes
Sep 5, 2022
Member
jessopb
left a comment
There was a problem hiding this comment.
Just the linter complaining:
Error --------------------------------------------------------------------------------- ui/redux/actions/claims.js:93:22
Cannot get `uriResolveInfo.error.censor` because property `censor` is missing in mixed [1].
ui/redux/actions/claims.js:93:22
93| ...uriResolveInfo.error.censor,
^^^^^^^^^^^^^^^^^^^^^^^^^^^
References:
/tmp/flow/flowlib_61141ec/core.js:48:51
48| static entries(object: mixed): Array<[string, mixed]>;
^^^^^ [1]
Error --------------------------------------------------------------------------------- ui/redux/actions/claims.js:94:25
Cannot get `uriResolveInfo.error.text` because property `text` is missing in mixed [1].
ui/redux/actions/claims.js:94:25
94| text: uriResolveInfo.error.text,
^^^^^^^^^^^^^^^^^^^^^^^^^
References:
/tmp/flow/flowlib_61141ec/core.js:48:51
48| static entries(object: mixed): Array<[string, mixed]>;
^^^^^ [1]
```
Collaborator
Author
|
Thank you @jessopb, sadly I couldn't fix it without using I tried typecasting but it kept complaining about not being compatible with |
Member
|
This will be merged when infrastructure is ready. |
jessopb
approved these changes
Sep 19, 2022
29dbbc2 to
6d52763
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Issue Number: #7681
What is the current behavior?
What is the new behavior?
blocked & filtered actions/selector/reducers were removed.
Also, if there is a censor reason, we will display it.
If no message is present, the default one will be used
("Your hub has blocked this content because it subscribes to the following blocking channel:")
Other information
PR Checklist
Toggle...
What kind of change does this PR introduce?
Please check all that apply to this PR using "x":