Skip to content

fix: add missing .ofNats in lake translate-config #11771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
eric-wieser wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: add missing .ofNats in lake translate-config #11771

eric-wieser wants to merge 1 commit into from
+1 −1

Conversation

@eric-wieser
Copy link
Contributor

@eric-wieser eric-wieser commented Dec 22, 2025 •
edited
Loading

This PR prevents the output of lake translate-config, on numeric options, complaining with

failed to synthesize
  OfNat Lean.LeanOptionValue 3

The alternative would be to add the missing instance.

@eric-wieser
fix: add missing .ofNats in lake translate-config
0f2797e 
This PR prevents the output of `lake translate-config` complaining with
```
failed to synthesize
  OfNat Lean.LeanOptionValue 3
```

The alternative would be to add the missing instance.
@eric-wieser eric-wieser requested a review from tydeu as a code owner December 22, 2025 20:09
@eric-wieser
Copy link
Contributor Author

eric-wieser commented Dec 22, 2025

changelog-lake

@github-actions github-actions bot added changelog-lake Lake toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN labels Dec 22, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Dec 22, 2025

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase dc53fac626e6ef43d1a2c05829d8844da22f3ec5 --onto 13c88f960f40b7c163b99e742010bbbbdbe8bba7. You can force Mathlib CI using the force-mathlib-ci label. (2025-12-22 21:06:11)

@leanprover-bot
Copy link
Collaborator

leanprover-bot commented Dec 22, 2025

Reference manual CI status:

  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase dc53fac626e6ef43d1a2c05829d8844da22f3ec5 --onto f317e28d842bad09a6111e1f72dda8a2c0bdc3c5. You can force reference manual CI using the force-manual-ci label. (2025-12-22 21:06:13)

@tydeu
Copy link
Member

tydeu commented Dec 28, 2025

I think the better fix for this would be adding the missing OfNat instance to LeanOptionValue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tydeu tydeu Awaiting requested review from tydeu tydeu is a code owner

Assignees

No one assigned

Labels

changelog-lake Lake toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eric-wieser @leanprover-community-bot @leanprover-bot @tydeu