feat: suggest guillemet escaping in parser error #11822
Draft
+13
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alok
force-pushed
the
feat/guillemet-hint-minimal
branch
3 times, most recently
from
b12f952 to
b243717
Compare
…cted When a token/keyword appears where an identifier is expected, the error message now suggests wrapping it in guillemets (e.g., `«if»`).
alok
force-pushed
the
feat/guillemet-hint-minimal
branch
from
b243717 to
a39d9c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the parser error message when a keyword/token is used where an identifier is expected.
Before:
unexpected token 'if'After:
unexpected token \if`; if you intended to use it as an identifier, use `«if»``Only shows the hint when an identifier is expected and the token is valid for escaping.
Suggested label:
changelog-language