Fix hook imports to align with Kolibri PR #12879#265
Merged
Conversation
- ShareFileHook moved from kolibri.core.device.hooks to kolibri.core.content.hooks - StorageHook renamed to JobHook in kolibri.core.tasks.hooks - Updated share_file signature to match new API (filename, message) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes import paths in
kolibri_plugin.pyto match the hook locations in Kolibri PR learningequality/kolibri#12879:ShareFileHook:kolibri.core.device.hooks→kolibri.core.content.hooksStorageHook→JobHookinkolibri.core.tasks.hooksshare_filesignature updated to match new API (filename,message)Also bumps
android_installer_versionto 0.1.9.References
Reviewer guidance
Build an APK against the
hooked_on_pluginsbranch of Kolibri and verify the app launches withoutImportErrorcrashes.AI usage
Used Claude Code to smoke test an APK on an emulator, diagnose the startup crash from logcat, cross-reference the hook import paths against learningequality/kolibri#12879, and make the fixes.