Skip to content

Upgrade morango to resolve dirty-bit issue and cleanup#14683

Merged
rtibbles merged 3 commits intolearningequality:developfrom
bjester:dirty-morango-bug
May 6, 2026
Merged

Upgrade morango to resolve dirty-bit issue and cleanup#14683
rtibbles merged 3 commits intolearningequality:developfrom
bjester:dirty-morango-bug

Conversation

@bjester
Copy link
Copy Markdown
Member

@bjester bjester commented May 5, 2026

Summary

  • Upgrades Morango which includes a fix to correct behavior handling the dirty bit when models are saved with update_fields
  • Adds regression tests for the existing logging functionality that was avoiding this issue

Verifications

Tests added to verify existing fix

image

Existing fix is removed exposing failed tests

image

Morango is upgraded showing it covers existing fix

image

References

learningequality/morango#326

Reviewer guidance

See verifications list above, which shows:

  1. The existing logging API handled this issue manually
  2. Without that manual fix, those cases are problematic
  3. Morango solves the issue and removes the need for the manual fix

This methodology was for the benefit of the reviewer. After review, I think we could drop the first commit, which adds the tests, with confidence in Morango, but feel free to specify otherwise.

AI usage

Asked AI to write the tests, but I had to update how they were setting the dirty bit to False before the actual scenario.

@github-actions github-actions Bot added DEV: backend Python, databases, networking, filesystem... SIZE: small and removed DEV: backend Python, databases, networking, filesystem... labels May 5, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

@bjester bjester force-pushed the dirty-morango-bug branch from 1632350 to e5236f1 Compare May 5, 2026 21:40
@github-actions github-actions Bot added the DEV: backend Python, databases, networking, filesystem... label May 5, 2026
@bjester bjester marked this pull request as ready for review May 5, 2026 23:58
@rtibbles rtibbles merged commit 2cc4cd3 into learningequality:develop May 6, 2026
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DEV: backend Python, databases, networking, filesystem... SIZE: small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants