Upgrade morango to resolve dirty-bit issue and cleanup#14683
Merged
rtibbles merged 3 commits intolearningequality:developfrom May 6, 2026
Merged
Upgrade morango to resolve dirty-bit issue and cleanup#14683rtibbles merged 3 commits intolearningequality:developfrom
rtibbles merged 3 commits intolearningequality:developfrom
Conversation
Contributor
Build Artifacts
Smoke test screenshot |
rtibbles
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
update_fieldsVerifications
Tests added to verify existing fix
Existing fix is removed exposing failed tests
Morango is upgraded showing it covers existing fix
References
learningequality/morango#326
Reviewer guidance
See verifications list above, which shows:
This methodology was for the benefit of the reviewer. After review, I think we could drop the first commit, which adds the tests, with confidence in Morango, but feel free to specify otherwise.
AI usage
Asked AI to write the tests, but I had to update how they were setting the dirty bit to
Falsebefore the actual scenario.