issue#178 Refactor Subplugins Calls#293
Open
ScottVerbeek wants to merge 2 commits intolearnweb:mainfrom
Open
Conversation
Contributor
Author
|
Just a heads up that I am working on the CI phpcs issues. |
47c14fd to
3ef4851
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔀 Purpose of this PR:
📝 Description:
This merge request will add the functionality to add lifecycle sub plugins outside of the lifecycle plugin. This way one can develop a plugin seperately, eg https://github.com/catalyst/moodle-tool_lcprunecourselogstep
For more information on what this is and how it works see the issue #178
📋 Checklist
Please confirm the following (check all that apply):
phpunitand/orbehattests that cover my changes or additions.var_dump()orvar_exportor any other debugging statements (or commented out code) thatshould not appear on the productive branch.
db/upgrade.phpandupdated the
version.php..minfiles with thegrunt amdcommand.version.phpand theCHANGES.md.I ran all tests thoroughly checking for errors. I checked if bootstrap had any changes/deprecations that require
changes in the plugins UI.
🔍 Related Issues
🧾📸🌐 Additional Information (like screenshots, documentation, links, etc.)
Here is how the refactor would work. After installing the tool with this version. You can add plugins outside of the support of the core set. This would reduce the maintainability of what may be an ever growing list of triggers and steps. You can install for example: