Skip to content

issue#178 Refactor Subplugins Calls#293

Open
ScottVerbeek wants to merge 2 commits intolearnweb:mainfrom
catalyst:issue-178-refactor-subplugin-design
Open

issue#178 Refactor Subplugins Calls#293
ScottVerbeek wants to merge 2 commits intolearnweb:mainfrom
catalyst:issue-178-refactor-subplugin-design

Conversation

@ScottVerbeek
Copy link
Contributor

@ScottVerbeek ScottVerbeek commented Mar 5, 2026

Note: Please fill out all relevant sections and remove irrelevant ones.

🔀 Purpose of this PR:

  • Adds a new feature of functionality
  • Improves or enhances existing features
  • Refactoring: restructures code for better performance or maintainability
  • Testing: add missing or improve existing tests

📝 Description:

This merge request will add the functionality to add lifecycle sub plugins outside of the lifecycle plugin. This way one can develop a plugin seperately, eg https://github.com/catalyst/moodle-tool_lcprunecourselogstep

For more information on what this is and how it works see the issue #178


📋 Checklist

Please confirm the following (check all that apply):

  • I have phpunit and/or behat tests that cover my changes or additions.
  • Code passes the code checker without errors and warnings.
  • Code passes the moodle-ci/cd pipeline on all supported Moodle versions or the ones the plugin supports.
  • Code does not have var_dump() or var_export or any other debugging statements (or commented out code) that
    should not appear on the productive branch.
  • Code only uses language strings instead of hard-coded strings.
  • If there are changes in the database: I updated/created the necessary upgrade steps in db/upgrade.php and
    updated the version.php.
  • If there are changes in javascript: I build new .min files with the grunt amd command.
  • If it is a Moodle update PR: I read the release notes, updated the version.php and the CHANGES.md.
    I ran all tests thoroughly checking for errors. I checked if bootstrap had any changes/deprecations that require
    changes in the plugins UI.

🔍 Related Issues


🧾📸🌐 Additional Information (like screenshots, documentation, links, etc.)

Here is how the refactor would work. After installing the tool with this version. You can add plugins outside of the support of the core set. This would reduce the maintainability of what may be an ever growing list of triggers and steps. You can install for example:

@ScottVerbeek
Copy link
Contributor Author

Just a heads up that I am working on the CI phpcs issues.

@ScottVerbeek ScottVerbeek force-pushed the issue-178-refactor-subplugin-design branch from 47c14fd to 3ef4851 Compare March 6, 2026 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants