Colour selector for LiDAR #33
Draft
Soldann wants to merge 5 commits into
Draft
Conversation
… it allocates memory each call
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds the capability to select exactly which field to pass as a colour value into the LiDAR renderer, allowing the viewer to adapt to any kind of pointcloud data. Users can still choose between intensity and RGB visualization, however the intensity option now can not only automatically determine the intensity range from the min and max values, but also can be manually set by the user.
Also, a new RSL.Core.Utils component was created, in this case to add new functions to convert Unity values into bytes, bypassing the byte array allocation that happens in System.BitConverter.GetBytes and thus improving efficiency