Remove arbitrarly chosen extra_float_digits connection option. #1150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Author
|
It caused me some problems and I would prefer the driver to stick to the database default (or at least document it). Imho it should be like with default libs, if a user uses simple connector, it should use the default config, but it should also be possible to pass user specific config. I can provide simple proof-of-concept. I've forked the lib and using my fork to not mess others people assumed behavior. |
arp242
added a commit
that referenced
this pull request
Jan 1, 2026
In PostgreSQL ≤11 the extra_float_digits parameter controlled how many digits were used for floating point numbers. It was set here to ensure people didn't accidentally needlessly lose precision (in 78a464e it was set to 3. In 5941153 it was changed to 2 as people reported problems on PostgreSQL ≤8.4, see #199). Since PostgreSQL 12 it will always use maximum precision unless it's set to ≤0. We only support PostgreSQL ≥14 now, so we can just remove it here. Ref: https://www.postgresql.org/docs/current/datatype-numeric.html#DATATYPE-FLOAT Fixes #475 Fixes #1150 Fixes #1146
Collaborator
|
Fixed via #1212 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.