Skip to content

Change silent payment scan_key to ec_secret. #1896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evoskuil merged 1 commit into from
Jun 25, 2026
+3 −3
Merged

Change silent payment scan_key to ec_secret. #1896

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/bitcoin/system/crypto/secp256k1_batch.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ struct BC_API batch
batched::tx_link link;

static void scan(const stopper& cancel, const span& batch,
const ec_compressed& scan_key, const handler& callback) NOEXCEPT;
const ec_secret& scan_key, const handler& callback) NOEXCEPT;
};

} // namespace silent
Expand Down
4 changes: 2 additions & 2 deletions src/crypto/secp256k1/batch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,7 @@ links_t schnorr::batch::verify(const stopper& cancel,
#if defined(HAVE_ULTRAFAST)

void silent::batch::scan(const stopper& , const span& ,
const ec_compressed& , const handler& ) NOEXCEPT
const ec_secret& , const handler& ) NOEXCEPT
{
// TODO: iterate over chunked subsets or entire set.
// TODO: correlate matches to tx link column and invoke callback.
Expand All @@ -357,7 +357,7 @@ void silent::batch::scan(const stopper& , const span& ,
#else

void silent::batch::scan(const stopper& , const span& ,
const ec_compressed& , const handler& ) NOEXCEPT
const ec_secret& , const handler& ) NOEXCEPT
{
// TODO: iterate results set in cancellable parallel loop over full space.
// TODO: correlate matches to tx link and invoke callback.
Expand Down
Loading