Match exact record data when rediscovering IDs for deletion#5
Open
bjornmp wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change makes
DeleteRecordsmatch existing records by name, type, and data when it needs to rediscover a Njalla record ID. Previously the fallback lookup matched only name and type.Why
When
DeleteRecordsis called without provider-specific ID data, the provider has to list records and find the matching Njalla ID before callingremove-record.Matching only name and type is not precise enough. Multiple TXT records with the same name and type can exist at the same time, with different values. The fallback lookup should therefore include the record data/value to avoid deleting the wrong record.
Related: caddyserver/certmagic#382 would preserve provider metadata during CertMagic DNS-01 cleanup, making Njalla's provider ID available more often and reducing how often this fallback path is needed there. This fallback should still be correct for callers that pass only portable DNS record data without provider-specific ID metadata.
Validation
Added regression unit tests for:
AppendRecords(...).RR()drops provider-specific metadataTested with:
go test ./...Fixes #4