Automatically set labels for Rule - #754
Draft
hoangpn wants to merge 1 commit into
Draft
Conversation
hoangpn
force-pushed
the
feature/automatically_set_label_for_rule
branch
from
July 22, 2026 08:17
4e22237 to
5bbd8d7
Compare
hoangpn
changed the title
hoangpn
force-pushed
the
feature/automatically_set_label_for_rule
branch
from
July 23, 2026 02:38
77a4024 to
5bbd8d7
Compare
We have changed to set the value of the Rule's "service" and "project" labels to always match the name of the Service and Project at the models layer instead of views layer. This ensures that user will not be able to modify these labels and Alerts from Alertmanager are correctly routed to the Service or Project that the Rule belongs to.
hoangpn
force-pushed
the
feature/automatically_set_label_for_rule
branch
from
July 23, 2026 02:38
5bbd8d7 to
971f9b9
Compare
hoangpn
marked this pull request as draft
July 24, 2026 04:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have changed to set the value of the Rule's "service" and "project" labels to always match the name of the Service and Project at the models layer instead of views layer. This ensures that user will not be able to modify these labels and Alerts from Alertmanager are correctly routed to the Service or Project that the Rule belongs to.