Replace ICommandLineInterface with ICli from Platform.Interfaces library#35
Open
konard wants to merge 3 commits into
Open
Replace ICommandLineInterface with ICli from Platform.Interfaces library#35konard wants to merge 3 commits into
konard wants to merge 3 commits into
Conversation
Adding CLAUDE.md with task information for AI processing. This file will be removed when the task is complete. Issue: #4
- Added Platform.Interfaces dependency (version 0.5.0) - Updated all CLI classes to implement ICli instead of ICommandLineInterface - Changed Run method signatures to return int (exit code) instead of void - Added appropriate return values (0 for success, 1 for error conditions) - Updated version to 0.0.4 and release notes 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
konard
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request resolves issue #4 by replacing the custom
ICommandLineInterfacewith the standardizedICliinterface from the Platform.Interfaces library.Changes Made
ICliinstead ofICommandLineInterface:XmlImporterCLI.csXmlExporterCLI.csXmlElementCounterCLI.csvoid Run(params string[] args)toint Run(params string[] args)to match theICliinterfaceTechnical Details
The Platform.Interfaces library already contains an
ICliinterface that serves the same purpose as the removedICommandLineInterface. The key difference is thatICli.Run()returns an integer exit code (following Unix conventions), while the original interface returned void.All CLI implementations now properly return:
0on successful execution1on error conditions (file not found, invalid arguments, cancellation, etc.)Test Results
✅ Build succeeds with no compilation errors
✅ All existing functionality preserved
✅ Follows established patterns in the LinksPlatform ecosystem
Fixes #4
🤖 Generated with Claude Code