-
Notifications
You must be signed in to change notification settings - Fork 391
change: [UIE-9860] - Change the default selection of network interface type to linode interface in Linode create flow #13221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
fb358c4 to
fb8b1a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
heads up - I haven't run the cypress tests locally, but they look related since they have to do with the Linode Create tests
oh whoops my other comment didn't get submitted 😅
| accountSetting === 'linode_only' || | ||
| accountSetting === 'linode_default_but_legacy_config_allowed' | ||
| accountSetting === 'linode_default_but_legacy_config_allowed' || | ||
| accountSetting === 'legacy_config_default_but_linode_allowed' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would it make more sense to instead remove legacy_config_default_but_linode_allowed as an option in the Account Settings page?
reading through the aha, I also like Daniel's suggestion for a single setting. Although I understand legacy_config_default_but_linode_allowed is more for the API and doesn't have to correspond to CM's preselected default value, I feel like the current mismatch could lead to confusion + we'd have to be careful in our explanation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently we don't have requirement to remove legacy_config_default_but_linode_allowed option from account settings page and hence we will continue to have all the options as we had earlier. So removal of legacy_config_default_but_linode_allowed from this logic will be error prone. cc: @dabaka
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @coliu-akamai we don't have expectation that the account setting will have a bearing on the Linode Create option.
We had the idea to add some 'this is most relevant for the API' text, but not sure if that is weird in general or weird to have in the UI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it, thanks @grevanak-akamai and @dabaka!
dwiley-akamai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran some of the E2E tests locally and the failures do appear to be related to these changes
| "@linode/manager": Changed | ||
| --- | ||
|
|
||
| Change the default selection of network interface type to linode interface in Linode create flow ([#13221](https://github.com/linode/manager/pull/13221)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Change the default selection of network interface type to linode interface in Linode create flow ([#13221](https://github.com/linode/manager/pull/13221)) | |
| Default selection of network interface type to linode interface in Linode create flow ([#13221](https://github.com/linode/manager/pull/13221)) |
2628d5f to
da9017d
Compare
… in Linode create flow
…pe to linode interface in Linode create flow
da9017d to
045cfa7
Compare
Fixed the e2e test cases that were failing and pushed the changes in this commit. |
Cloud Manager UI test results🔺 1 failing test on test run #7 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/linodes/clone-linode.spec.ts" |
|||||||||||||||||
coliu-akamai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ network interface type in Linode create is only "Config interfaces" when our account setting is "Config interfaces only"
✅ otherwise, the default is always "Linode"
thanks @grevanak-akamai
| accountSetting === 'linode_only' || | ||
| accountSetting === 'linode_default_but_legacy_config_allowed' | ||
| accountSetting === 'linode_default_but_legacy_config_allowed' || | ||
| accountSetting === 'legacy_config_default_but_linode_allowed' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it, thanks @grevanak-akamai and @dabaka!
Description 📝
Change the default selection of network interface type from legacy 'configuration profile' to 'linode interface' in Linode create flow.
Changes 🔄
getDefaultInterfaceGenerationFromAccountSettingutility functionScope 🚢
Upon production release, changes in this PR will be visible to:
Target release date 🗓️
NA
Preview 📷
How to test 🧪
Prerequisites
Verification steps
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅