Skip to content

Conversation

@grevanak-akamai
Copy link
Contributor

@grevanak-akamai grevanak-akamai commented Dec 23, 2025

Description 📝

Change the default selection of network interface type from legacy 'configuration profile' to 'linode interface' in Linode create flow.

Changes 🔄

  • Changed default value of interface generation type to 'linode' in getDefaultInterfaceGenerationFromAccountSetting utility function

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Target release date 🗓️

NA

Preview 📷

Before After
Screenshot 2025-12-23 at 12 13 09 PM Screenshot 2025-12-23 at 12 28 07 PM

How to test 🧪

Prerequisites

  • In account settings, ensure the network interface type for new linodes is "config profile but allow Linode interface"

Verification steps

  • Network interface type in Linode create flow should be "Linode interfaces" by default.
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@grevanak-akamai grevanak-akamai requested a review from a team as a code owner December 23, 2025 07:20
@grevanak-akamai grevanak-akamai changed the title change: [UIE-9860] - Change the default selection to linode interface in Linode create flow change: [UIE-9860] - Change the default selection of network interface type to linode interface in Linode create flow Dec 23, 2025
@grevanak-akamai grevanak-akamai force-pushed the feature/UIE-9860-change-default-selection-to-linode-interface branch from fb358c4 to fb8b1a6 Compare December 23, 2025 12:18
@grevanak-akamai grevanak-akamai added the Linodes Dealing with the Linodes section of the app label Dec 23, 2025
@grevanak-akamai grevanak-akamai self-assigned this Dec 23, 2025
@bnussman-akamai bnussman-akamai added the Related Cypress Test Failure Test failure(s) are the result of changes in this PR and must be addressed before merging. label Dec 23, 2025
Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heads up - I haven't run the cypress tests locally, but they look related since they have to do with the Linode Create tests

oh whoops my other comment didn't get submitted 😅

accountSetting === 'linode_only' ||
accountSetting === 'linode_default_but_legacy_config_allowed'
accountSetting === 'linode_default_but_legacy_config_allowed' ||
accountSetting === 'legacy_config_default_but_linode_allowed'
Copy link
Contributor

@coliu-akamai coliu-akamai Jan 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it make more sense to instead remove legacy_config_default_but_linode_allowed as an option in the Account Settings page?

reading through the aha, I also like Daniel's suggestion for a single setting. Although I understand legacy_config_default_but_linode_allowed is more for the API and doesn't have to correspond to CM's preselected default value, I feel like the current mismatch could lead to confusion + we'd have to be careful in our explanation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently we don't have requirement to remove legacy_config_default_but_linode_allowed option from account settings page and hence we will continue to have all the options as we had earlier. So removal of legacy_config_default_but_linode_allowed from this logic will be error prone. cc: @dabaka

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @coliu-akamai we don't have expectation that the account setting will have a bearing on the Linode Create option.

We had the idea to add some 'this is most relevant for the API' text, but not sure if that is weird in general or weird to have in the UI.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it, thanks @grevanak-akamai and @dabaka!

Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran some of the E2E tests locally and the failures do appear to be related to these changes

"@linode/manager": Changed
---

Change the default selection of network interface type to linode interface in Linode create flow ([#13221](https://github.com/linode/manager/pull/13221))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Change the default selection of network interface type to linode interface in Linode create flow ([#13221](https://github.com/linode/manager/pull/13221))
Default selection of network interface type to linode interface in Linode create flow ([#13221](https://github.com/linode/manager/pull/13221))

@grevanak-akamai grevanak-akamai force-pushed the feature/UIE-9860-change-default-selection-to-linode-interface branch from 2628d5f to da9017d Compare January 7, 2026 15:35
@grevanak-akamai grevanak-akamai force-pushed the feature/UIE-9860-change-default-selection-to-linode-interface branch from da9017d to 045cfa7 Compare January 8, 2026 12:08
@grevanak-akamai grevanak-akamai requested a review from a team as a code owner January 8, 2026 12:08
@grevanak-akamai grevanak-akamai requested review from cliu-akamai, coliu-akamai and dwiley-akamai and removed request for a team January 8, 2026 12:08
@grevanak-akamai
Copy link
Contributor Author

I ran some of the E2E tests locally and the failures do appear to be related to these changes

Fixed the e2e test cases that were failing and pushed the changes in this commit.

@grevanak-akamai grevanak-akamai removed the Related Cypress Test Failure Test failure(s) are the result of changes in this PR and must be addressed before merging. label Jan 8, 2026
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 1 failing test on test run #7 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
1 Failing854 Passing11 Skipped45m 12s

Details

Failing Tests
SpecTest
clone-linode.spec.tsCloud Manager Cypress Tests→clone linode » can clone a Linode from Linode details page

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/linodes/clone-linode.spec.ts"

Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ network interface type in Linode create is only "Config interfaces" when our account setting is "Config interfaces only"
✅ otherwise, the default is always "Linode"

thanks @grevanak-akamai

accountSetting === 'linode_only' ||
accountSetting === 'linode_default_but_legacy_config_allowed'
accountSetting === 'linode_default_but_legacy_config_allowed' ||
accountSetting === 'legacy_config_default_but_linode_allowed'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it, thanks @grevanak-akamai and @dabaka!

@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Linodes Dealing with the Linodes section of the app Ready for Review

Projects

Status: Approved

Development

Successfully merging this pull request may close these issues.

6 participants