Skip to content

daemon: Respond to Ctrl+C signal gracefully#127

Merged
iinuwa merged 1 commit intomainfrom
push-vykzzlmwpuvz
Feb 6, 2026
Merged

daemon: Respond to Ctrl+C signal gracefully#127
iinuwa merged 1 commit intomainfrom
push-vykzzlmwpuvz

Conversation

@iinuwa
Copy link
Member

@iinuwa iinuwa commented Feb 5, 2026

No description provided.

@kalvdans
Copy link

kalvdans commented Feb 5, 2026

Can you elaborate on what particular connection we need to be graceful? Usually closing a connection is graceful enough, and it's done anyway by the OS when the process quits.

@iinuwa
Copy link
Member Author

iinuwa commented Feb 5, 2026

@kalvdans, when running with a debugger in certain configurations (VS Code debug console), SIGINT/Ctrl+C was not working. This is just a developer quality-of-life improvement

@kalvdans
Copy link

kalvdans commented Feb 5, 2026

@kalvdans, when running with a debugger in certain configurations (VS Code debug console), SIGINT/Ctrl+C was not working. This is just a developer quality-of-life improvement

Oh, why wasn't it working? It's supposed to kill the process by default.

@iinuwa
Copy link
Member Author

iinuwa commented Feb 5, 2026

🤷 Not sure. I still can't get it to kill the process when the debugger restarts, which is annoying.

@kalvdans
Copy link

kalvdans commented Feb 5, 2026

🤷 Not sure. I still can't get it to kill the process when the debugger restarts, which is annoying.

I guess we can start it in a debugger and break on calls to sigaction(). I'm not very good myself with rust, but I think we need to investigate who installs the signal handler to be able to block it at the source :)

@iinuwa iinuwa merged commit 0fad3f2 into main Feb 6, 2026
1 check passed
@iinuwa iinuwa deleted the push-vykzzlmwpuvz branch February 6, 2026 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants