Skip to content

daemon: Use string instead of PathBuf for app path #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iinuwa merged 1 commit into from
Feb 6, 2026
+4 −4
Merged

daemon: Use string instead of PathBuf for app path #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions credentialsd-common/src/model.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use std::{fmt::Display, path::PathBuf};
use std::fmt::Display;

use serde::{Deserialize, Serialize};
use zvariant::{SerializeDict, Type};
Expand Down Expand Up @@ -99,7 +99,7 @@ impl Transport {
#[derive(Debug, Default, Clone, Serialize, Deserialize, Type)]
pub struct RequestingApplication {
pub name: String,
pub path: PathBuf,
pub path: String,
pub pid: u32,
}

Expand Down
2 changes: 1 addition & 1 deletion credentialsd-ui/src/gui/view_model/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ impl<F: FlowController + Send> ViewModel<F> {
subtitle = subtitle.replace("%s1", &self.rp_id);
subtitle = subtitle.replace("%i1", &format!("{}", requesting_app.pid));
subtitle = subtitle.replace("%s2", &requesting_app.name);
subtitle = subtitle.replace("%s3", &requesting_app.path.to_string_lossy());
subtitle = subtitle.replace("%s3", &requesting_app.path);
self.title = title;
self.subtitle = subtitle;
self.tx_update
Expand Down
2 changes: 1 addition & 1 deletion credentialsd/src/dbus/gateway.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ async fn query_connection_peer_binary(

Some(RequestingApplication {
name: command_name,
path: exe_path,
path: exe_path.to_string_lossy().to_string(),
pid,
})
}
Expand Down