feature: automatically launch browser on bud run#334
Conversation
matthewmueller
left a comment
matthewmueller
left a comment
There was a problem hiding this comment.
Thanks for opening this PR!
| if !c.Flag.Noautolaunch { // if not not autolaunch, i.e. if autolaunch | ||
| go func() { | ||
| time.Sleep(1 * time.Second) | ||
| _ = browser.OpenURL("http://" + webln.Addr().String()) |
There was a problem hiding this comment.
Should check the error
There was a problem hiding this comment.
this is the only guidance here i don't understand. why? i literally can't think of anything that we'd do differently if it fails or not. it's an optional convenience feature...
There was a problem hiding this comment.
My take is that if a user explicitly requested --open we should open or fail trying.
|
Thanks for the review and feedback- I will update the PR soon. |
matthewmueller
left a comment
matthewmueller
left a comment
There was a problem hiding this comment.
Looks a lot better, thanks the update!
| cli.Flag("embed", "embed assets").Bool(&cmd.Flag.Embed).Default(false) | ||
| cli.Flag("hot", "hot reloading").Bool(&cmd.Flag.Hot).Default(true) | ||
| cli.Flag("minify", "minify assets").Bool(&cmd.Flag.Minify).Default(false) | ||
| cli.Flag("open", "open browser on dev server startup").Bool(&cmd.Flag.OpenBrowser).Default(false) |
There was a problem hiding this comment.
Ah sorry, I might have missed this in the previous review but Flag is meant for global options that need to get passed into the framework. We should treat OpenBrowser like Listen below and stick it on the run command.
sneak
force-pushed
the
sneak/open-browser
branch
from
abd4715 to
227541b
Compare
sneak
force-pushed
the
sneak/open-browser
branch
from
227541b to
31e089c
Compare
sneak
force-pushed
the
sneak/open-browser
branch
from
31e089c to
3ce87a8
Compare
2 participants
fixes #333