Skip to content

Use 'toURI()' before calling 'toURL()' #647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sschulz92 wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Use 'toURI()' before calling 'toURL()' #647

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7608251
Use 'toURI()' before calling 'toURL()'
sschulz92 Dec 13, 2021
23aa9f2
Merge branch 'master' into USE_toURI_BEFORE_toURL
sschulz92 Dec 28, 2021
b12e99c
Merge branch 'master' into USE_toURI_BEFORE_toURL
sschulz92 Jan 9, 2022
008d467
Merge branch 'master' into USE_toURI_BEFORE_toURL
sschulz92 Jan 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
239 changes: 121 additions & 118 deletions ...g.locationtech.udig.context/src/org/locationtech/udig/context/internal/URLWizardPage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
/* uDig - User Friendly Desktop Internet GIS client
/**
* uDig - User Friendly Desktop Internet GIS client
* http://udig.refractions.net
* (C) 2004, Refractions Research Inc.
*
Expand Down Expand Up @@ -33,236 +34,238 @@
/**
* The most basic, simple annoying URL prompt you can imagine.
* <p>
* This import page is similar the eclipse example and was
* last seen as the ShapefileImportPage in UDIG 0.7. Yes I am
* that lazy - lazy smart.
* This import page is similar the eclipse example and was last seen as the ShapefileImportPage in
* UDIG 0.7. Yes I am that lazy - lazy smart.
* </p>
* <p>
* This time around I am going to try and keep things
* reusable, so we can use this for Context Documents, SLD
* files whatever. Also will let us improve the "look" as
* needed.
* This time around I am going to try and keep things reusable, so we can use this for Context
* Documents, SLD files whatever. Also will let us improve the "look" as needed.
* </p>
* <p>
* The following user-interface elements are used:
* <ul>
* <li>text - will need to be a URL to proceed.
* (Valid file syntax will also do...)
* <li>browse - button used to bring up a file browser
* <li>text - will need to be a URL to proceed. (Valid file syntax will also do...)</li>
* <li>browse - button used to bring up a file browser</li>
* </ul>
* </p>
* <p>
* In the future - I would really like to hook this into the
* generic DnD system Jesse is working on for UDIG 1.1.x. In
* such a use the end of this process would be the URL being
* "dropped" onto the current selection.
* In the future - I would really like to hook this into the generic DnD system Jesse is working on
* for UDIG 1.1.x. In such a use the end of this process would be the URL being "dropped" onto the
* current selection.
* </p>
*
*
* @author Jody Garnett
* @since 1.0.5
*/
public class URLWizardPage extends WizardPage implements KeyListener {

protected URL url = null;

private Text text;
private String promptMessage = Messages.URLWizardPage_prompt_initial;


private String promptMessage = Messages.URLWizardPage_prompt_initial;

/**
* Force subclasses to actually cough up the stuff needed for
* a pretty user interface.
* Force subclasses to actually cough up the stuff needed for a pretty user interface.
* <p>
* Subclass should really:
* <ul>
* <li>setDescription
* <li>setMessage
* </ul>
* </p>
*
* @param pageName
* @param title
* @param titleImage
*/
protected URLWizardPage( String pageName, String title, ImageDescriptor titleImage ) {
protected URLWizardPage(String pageName, String title, ImageDescriptor titleImage) {
super(pageName, title, titleImage);
}
public void setMessage( String newMessage ) {
if( newMessage == null ) newMessage = promptMessage;

@Override
public void setMessage(String newMessage) {
if (newMessage == null)
newMessage = promptMessage;
super.setMessage(newMessage);
}

/**
* Called to create the user interface components.
* <p>
* As per usual eclipse practice, both the constructor (duh) and
* init have been called.
* As per usual eclipse practice, both the constructor (duh) and init have been called.
* </p>
*/
public void createControl( Composite parent ) {
Composite composite = new Composite(parent,SWT.NULL);
@Override
public void createControl(Composite parent) {
Composite composite = new Composite(parent, SWT.NULL);
composite.setLayout(new GridLayout(3, false));

// add url
Label label = new Label( composite, SWT.NONE );
label.setText(Messages.URLWizardPage_label_url_text );
label.setLayoutData( new GridData(SWT.END, SWT.DEFAULT, false, false ) );

text = new Text( composite, SWT.BORDER );
text.setLayoutData( new GridData(GridData.FILL_HORIZONTAL) );
text.setText( "" ); //$NON-NLS-1$
text.addKeyListener( this );

// add URL
Label label = new Label(composite, SWT.NONE);
label.setText(Messages.URLWizardPage_label_url_text);
label.setLayoutData(new GridData(SWT.END, SWT.DEFAULT, false, false));

text = new Text(composite, SWT.BORDER);
text.setLayoutData(new GridData(GridData.FILL_HORIZONTAL));
text.setText(""); //$NON-NLS-1$
text.addKeyListener(this);

Button button = new Button(composite, SWT.PUSH);
button.setLayoutData(new GridData());

button.setText(Messages.URLWizardPage_button_browse_text);
button.addSelectionListener(new SelectionAdapter(){
public void widgetSelected( SelectionEvent e ) {
button.setText(Messages.URLWizardPage_button_browse_text);
button.addSelectionListener(new SelectionAdapter() {
@Override
public void widgetSelected(SelectionEvent e) {
Display display = Display.getCurrent();
if (display == null) { // not on the ui thread?
if (display == null) { // not on the UI thread?
display = Display.getDefault();
}

FileDialog dialog = new FileDialog(display.getActiveShell(), SWT.OPEN);
//dialog.setFilterExtensions(new String[]{"*.shp"});
dialog.setText( Messages.URLWizardPage_dialog_text ); // hope for open ?

dialog.setText(Messages.URLWizardPage_dialog_text); // hope for open ?

String open = dialog.open();
if(open == null){
if (open == null) {
// canceled - no change
}
else {
text.setText( open );
setPageComplete(isPageComplete());
} else {
text.setText(open);
setPageComplete(isPageComplete());
}
}
});
});
setControl(text);
// eclipse ui guidelines say we must start with prompt (not error)
setMessage( null );
setPageComplete(true);

// Eclipse UI guidelines say we must start with prompt (not error)
setMessage(null);
setPageComplete(true);
}

/**
* We cannot assume how far we got in the consturction process.
* So we have to carefully tear the roof down over our heads and
* sweep away our footprints.
* We cannot assume how far we got in the construction process. So we have to carefully tear the
* roof down over our heads and sweep away our footprints.
*/
@Override
public void dispose() {
if( text != null ){
text.removeKeyListener( this );
if (text != null) {
text.removeKeyListener(this);
text.dispose();
text = null;
}
super.dispose();
}

public void keyReleased( KeyEvent e ) {
if(isPageComplete()){

@Override
public void keyReleased(KeyEvent e) {
if (isPageComplete()) {
setPageComplete(true);
}
}
public void keyPressed( KeyEvent e ) {

@Override
public void keyPressed(KeyEvent e) {
setPageComplete(false);
}

/**
* Default implementation will return true for a valid URL.
* <p>
* Valid URL is based on text containing:
* <ul>
* <li>URL that parses without exception
* <li>Text that can be treated as a File (and thus a URL)
* <li>URLs w/ the File protocol the file must exist!
* <li>URL that parses without exception</li>
* <li>Text that can be treated as a File (and thus a URL)</li>
* <li>URLs w/ the File protocol the file must exist!</li>
* </ul>
* Subclasses may override to perform extra sanity checks on
* the URL (for things like extention, magic, etc...)
* Subclasses may override to perform extra sanity checks on the URL (for things like extention,
* magic, etc...)
* </p>
*
*
* @see org.eclipse.jface.wizard.IWizardPage#isPageComplete()
* @return true if we have a useful URL
*/
@Override
public boolean isPageComplete() {
url = null;

String txt = text.getText();
Exception errorMessage = null;
if( txt == null || txt.length() == 0 ){
Exception errorMessage = null;

if (txt == null || txt.length() == 0) {
// not available
}
else {
} else {
try {
url = new URL( txt );
}
catch( MalformedURLException erp ){
url = new URL(txt);
} catch (MalformedURLException erp) {
errorMessage = erp;
}
if( errorMessage != null ){ // try file
if (errorMessage != null) { // try file
try {
File file = new File( txt );
url = file.toURL();
File file = new File(txt);
url = file.toURI().toURL();
errorMessage = null;
} catch (MalformedURLException notFile) {
}
}
}
if( url == null ){
if( errorMessage != null ){
setErrorMessage( errorMessage.getLocalizedMessage() );
if (url == null) {
if (errorMessage != null) {
setErrorMessage(errorMessage.getLocalizedMessage());
} else {
setMessage(""); //$NON-NLS-1$
}
else {
setMessage( "" ); //$NON-NLS-1$
}
}
setMessage( Messages.URLWizardPage_prompt_import );
}
setMessage(Messages.URLWizardPage_prompt_import);
return true;
}

/**
* Called as a quick sanity check on the provided url.
* Called as a quick sanity check on the provided URL.
* <p>
* Note this method is called before checking if the url
* is a file. You can assume that urlCheck is true if fileCheck
* is called.
* Note this method is called before checking if the URL is a file. You can assume that urlCheck
* is true if fileCheck is called.
* </p>
* <p>
* The default implementation just check that the url is non
* <code>null</code>. Please override to check for things like
* the correct extention ...
* The default implementation just check that the URL is non <code>null</code>. Please override
* to check for things like the correct extention ...
* </p>
*
*
* @param url
* @return true if url is okay
* @return true if URL is okay
*/
protected boolean urlCheck( URL url ){
protected boolean urlCheck(URL url) {
return url != null;
}

/**
* Used for a <b>quick</b> file check - don't open it!
* <p>
* Default implementation checks that the file exists, override
* to check file extention or permissions or something.
* Default implementation checks that the file exists, override to check file extention or
* permissions or something.
* </p>
* <p>
* This method is being called on every key press so don't
* waste your user's time. Save that till they hit Next, that
* way you get a progress monitor...
* This method is being called on every key press so don't waste your user's time. Save that
* till they hit Next, that way you get a progress monitor...
* </p>
* <p>
* Method can call setErrorMessage to report reasonable user
* level explainations back to the user, default implementation
* will complain if the file does not exist.
* Method can call setErrorMessage to report reasonable user level explanations back to the
* user, default implementation will complain if the file does not exist.
* </p>
*
* @param file
* @return true if file passes a quick sanity check
*/
protected boolean fileCheck( File file ){
if( file.exists() ){
protected boolean fileCheck(File file) {
if (file.exists()) {
return true;
}
//file = file.getAbsoluteFile();
while( file.getParent() != null && !file.exists() ){
}
// file = file.getAbsoluteFile();
while (file.getParent() != null && !file.exists()) {
file = file.getParentFile();
}
setErrorMessage( MessageFormat.format(Messages.URLWizardPage_prompt_error_fileNotExist, file.getName()));

setErrorMessage(MessageFormat.format(Messages.URLWizardPage_prompt_error_fileNotExist,
file.getName()));

return false;
}
}
Loading