Sync upstream v1.1.2 and remove duplicate goal implementation#2
Merged
Conversation
* Update codex to 0.142.2 * fix: verify types and tests after codex update --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Also sets up dependabot for just actions
* Add missing TypeScript semicolons * Remove unused ACP namespace import * Remove unused stdin close argument * Clarify release archive and Codex update docs * Remove duplicate sed range script pattern
…col#220) * fix: keep exec command fallback tracking consistent * Test response item history fallback statuses
Matches replay behavior. Closes agentclientprotocol#222
) Has the behavior from the old adapter of reading the env vars if one isn't supplied. Closes agentclientprotocol#234
…tprotocol#241) Bumps the github-actions group with 3 updates: [actions/checkout](https://github.com/actions/checkout), [actions/create-github-app-token](https://github.com/actions/create-github-app-token) and [softprops/action-gh-release](https://github.com/softprops/action-gh-release). Updates `actions/checkout` from 4 to 7 - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4...v7) Updates `actions/create-github-app-token` from 2 to 3 - [Release notes](https://github.com/actions/create-github-app-token/releases) - [Changelog](https://github.com/actions/create-github-app-token/blob/main/CHANGELOG.md) - [Commits](actions/create-github-app-token@v2...v3) Updates `softprops/action-gh-release` from 2.6.2 to 3.0.1 - [Release notes](https://github.com/softprops/action-gh-release/releases) - [Changelog](https://github.com/softprops/action-gh-release/blob/master/CHANGELOG.md) - [Commits](softprops/action-gh-release@3bb1273...718ea10) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '7' dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions - dependency-name: actions/create-github-app-token dependency-version: '3' dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions - dependency-name: softprops/action-gh-release dependency-version: 3.0.1 dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Handle ACP request cancellation ACP SDK v0.29.0 added support for the draft of request cancellation. * Resolve turn interruption only on close cancellation
…ocol#224) When resuming or loading a session, getResumeModelProvider() now reads the model_provider value from Codex config (config/read) before falling back to "openai". This fixes a v1.0.0 regression where sessions resumed via ACP always used OpenAI even when ~/.codex/config.toml specified model_provider = "azure".
* fix: Track configured auth for turn errors Closes agentclientprotocol#244 * Clear session auth state on logout * Refresh session auth state after logout * Refresh session auth state after login * Treat custom providers as auth configured * Track auth state by model provider * Normalize configured auth error responses * Test provider auth state for restored sessions
…default (agentclientprotocol#199) * fix: keep configured model id for custom providers instead of forcing the default createModelId() looked up the configured/returned model id in Codex's listModels() catalog and, when it was absent, substituted availableModels.find(m => m.isDefault). Custom providers (self-hosted or third-party endpoints) expose model ids that the catalog does not enumerate, so this silently replaced the user's configured model with the built-in default. That default id was then pinned onto every runTurn, making requests to the custom endpoint fail with "unknown model '<default>'". The Codex CLI handles the same case by keeping the configured model id and warning "Model metadata not found. Defaulting to fallback metadata." This change mirrors that behavior: keep the requested model id when it is not in the catalog, and only fall back to isDefault when no model id was provided at all. Downstream session state already degrades gracefully for unknown models (supportedReasoningEfforts ?? [], inputModalities ?? ["text","image"]). Adds unit tests covering an uncatalogued model id with and without an explicit reasoning effort. * Handle uncataloged current models in config --------- Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com>
* Update codex to 0.142.3 * Fix types and tests after Codex update --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Update codex to 0.142.4 * Fix types and tests after Codex update --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* feat: Add /goal support * Suppress multiple identical notifications * Wait on turns * Wait for goal turn * Add newlines after notifications * Remove unsupported edit subcommand * Handle goal commands without continuation turns * Separate goal status updates from prior text * Potential fix for pull request finding 'Unused variable, import, function or class' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com> * Interrupt late-started goal commands on cancel * Suppress stale turn notifications after routing them * Wait for thread idle when no goal turn starts * Handle cancellation before goal turn routing * Wait for goal updates before finishing goal set * Add grace periods for goal turn routing * Wait for goal notifications in ACP client * Wait for goal turn completion before resolving * Potential fix for pull request finding 'Unused variable, import, function or class' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com> --------- Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Use the active ACP session roots when publishing skill commands and handling /skills so Codex app-server does not fall back to the adapter process cwd. Adds a portable e2e regression for repo-local skills under the session workspace. Fixes agentclientprotocol#250
* Update ACP SDK v1.1 and dev tools * Update diff dependency to v9
* Update codex to 0.142.5 * Fix types and tests after Codex update --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
These were quite noisy and not always helpful. We can revisit with a new status api in ACP
* Support boolean Fast mode config options If the client expresses support for boolean config options, we can provide it. * Set fast mode config category to model config
…entclientprotocol#273) Bumps the github-actions group with 1 update: [openai/codex-action](https://github.com/openai/codex-action). Updates `openai/codex-action` from 1.9 to 1.11 - [Changelog](https://github.com/openai/codex-action/blob/main/CHANGELOG.md) - [Commits](openai/codex-action@10cb888...52fe01e) --- updated-dependencies: - dependency-name: openai/codex-action dependency-version: '1.11' dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github-actions ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Support ACP form elicitation capability * Auto-resolve stale user input elicitations * Support Other answers in user input elicitations * Complete accepted URL elicitations on resolution * Disable app-server elicitation opt-in * Remove request_user_input handling
Also uses the elicitation helpers
# Conflicts: # .github/workflows/e2e.yml # package-lock.json # package.json # readme-dev.md # src/CodexAcpServer.ts # src/CodexAppServerClient.ts # src/CodexCommands.ts # src/CodexEventHandler.ts # src/__tests__/CodexACPAgent/CodexAcpClient.test.ts # src/__tests__/CodexACPAgent/data/thread-goal-cleared.json # src/__tests__/CodexACPAgent/data/thread-goal-updated-multiline.json # src/__tests__/CodexACPAgent/data/thread-goal-updated.json # src/__tests__/CodexACPAgent/thread-goal-events.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agentclientprotocol/codex-acpupstream through v1.1.2/goalcommand supportthread/goal/*extension surface and local goal implementationUpstream functionality included
session_info_update._meta.codex.goalVerification
npm run typechecknpm test(295 passed, 28 skipped)npm run build