test: remove flaky MCP prompt integration case#5
Merged
Conversation
Drop the nonessential slash-command assertion that intermittently waits for a real Codex response until the 40-second suite timeout. Model: gpt-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the nonessential MCP config merge test that starts a real Codex process, sends
/mcp, and waits for rendered output.Why
The test intermittently reaches the suite's 40-second timeout while waiting for an external Codex response. It failed Lody PR #2869 even though that PR only changes CLI Presence code and the submodule SHA was unchanged.
The deterministic
DISABLE_MCP_CONFIG_FILTERINGbehavior test remains in the file.Impact
No production code changes. This removes an unreliable integration assertion from the default unit-test suite.
Validation
pnpm --filter acp-extension-codex exec vitest run src/__tests__/CodexACPAgent/mcp-config-merge.test.tspnpm --filter acp-extension-codex typecheckpnpm --filter acp-extension-codex test— 300 passed, 28 skipped